Skip to content

Commit

Permalink
issue nhibernate#3363: single failing test with single failing statemet
Browse files Browse the repository at this point in the history
  • Loading branch information
FelicePollano committed Jul 18, 2023
1 parent 9023921 commit 10869d5
Show file tree
Hide file tree
Showing 2 changed files with 148 additions and 0 deletions.
29 changes: 29 additions & 0 deletions src/NHibernate.Test/NHSpecificTest/GH3363/Entities.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
using System;

namespace NHibernate.Test.NHSpecificTest.GH3363
{
class Mother
{
public virtual int Id { get; set; }
public virtual string Name { get; set; }
}

class Child1 : Mother
{
public virtual Thing1 Thing { get; set; }
}
class Child2 : Mother
{
public virtual Thing2 Thing { get; set; }
}
class Thing1
{
public virtual string Id { get; set;}
public virtual string Name { get; set; }
}
class Thing2
{
public virtual string Id { get; set;}
public virtual string Name { get; set; }
}
}
119 changes: 119 additions & 0 deletions src/NHibernate.Test/NHSpecificTest/GH3363/FixtureByCode.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,119 @@
using System.Linq;
using NHibernate.Cfg.MappingSchema;
using NHibernate.DomainModel;
using NHibernate.Mapping.ByCode;
using NUnit.Framework;

namespace NHibernate.Test.NHSpecificTest.GH3363
{
/// <summary>
/// Fixture using 'by code' mappings
/// </summary>
/// <remarks>
/// This fixture is identical to <see cref="Fixture" /> except the <see cref="Entities" /> mapping is performed
/// by code in the GetMappings method, and does not require the <c>Mappings.hbm.xml</c> file. Use this approach
/// if you prefer.
/// </remarks>
[TestFixture]
public class ByCodeFixture : TestCaseMappingByCode
{
protected override HbmMapping GetMappings()
{
var mapper = new ModelMapper();

mapper.Class<Mother>(rc =>
{
rc.Id(x => x.Id, m => m.Generator(Generators.Identity));
rc.Property(x => x.Name);
rc.Discriminator(x => x.Column("kind"));
});
mapper.Subclass<Child1>(rc =>
{
rc.Property(x => x.Name);
rc.ManyToOne(x => x.Thing, m =>{
m.NotFound(NotFoundMode.Ignore);
m.Column("thingId");
});
rc.DiscriminatorValue(1);
});
mapper.Subclass<Child2>(rc =>
{
rc.Property(x => x.Name);
rc.ManyToOne(x => x.Thing, m => {
m.NotFound(NotFoundMode.Ignore);
m.Column("thingId");
});
rc.DiscriminatorValue(2);
});
mapper.Class<Thing1>(rc =>
{
rc.Id(x => x.Id, m => m.Generator(Generators.Assigned));
rc.Property(x => x.Name);
});
mapper.Class<Thing2>(rc =>
{
rc.Id(x => x.Id, m => m.Generator(Generators.Assigned));
rc.Property(x => x.Name);
});
return mapper.CompileMappingForAllExplicitlyAddedEntities();
}

protected override void OnSetUp()
{
using (var session = OpenSession())
using (var transaction = session.BeginTransaction())
{
var t1 = new Thing1() { Name = "don't care",Id="00001" };
session.Save(t1);
var t2 = new Thing2() { Name = "look for this",Id="00002" };
session.Save(t2);
var child1 = new Child1 { Name = "Child1",Thing=t1 };
session.Save(child1);
var child2 = new Child2 { Name = "Child1", Thing = t2 };
session.Save(child2);
transaction.Commit();
}
}

protected override void OnTearDown()
{
using (var session = OpenSession())
using (var transaction = session.BeginTransaction())
{
// The HQL delete does all the job inside the database without loading the entities, but it does
// not handle delete order for avoiding violating constraints if any. Use
// session.Delete("from System.Object");
// instead if in need of having NHbernate ordering the deletes, but this will cause
// loading the entities in the session.
session.CreateQuery("delete from System.Object").ExecuteUpdate();

transaction.Commit();
}
}

[Test]
public void LookForThingOfTypeThing1()
{
using (var session = OpenSession())
using (var transaction = session.BeginTransaction())
{
/*
* wrong statement created
* select mother0_.Id as id1_0_, mother0_.Name as name3_0_,
mother0_.thingId as thingid4_0_, mother0_.kind as kind2_0_ from Mother mother0_
left outer join Thing2 thing2x1_ on
mother0_.thingId=thing2x1_.Id where mother0_.kind='1' and thing2x1_.Id=?"
*
*/

var result = session.Query<Mother>().Where(k => k is Child1 && (k as Child1).Thing.Id == "00001").ToList();

Assert.That(result, Has.Count.EqualTo(1));
transaction.Commit();
}
}
}

}

0 comments on commit 10869d5

Please sign in to comment.