Fix minor syntax error in PM sending #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craftxbox
commented
Feb 25, 2025
| @@ -88,7 +88,7 @@ def send_mastodon_pm(self, message, username, domain): | |||
| document["object"]["tag"] = [ | |||
| { | |||
| "type": "Mention", | |||
| "to": f"@{username}", | |||
| "name": f"@{username}", | |||
There was a problem hiding this comment.
Hm, I set up my own GTS instance along with the fediseer to take over this and tested it at the time. I have to check what's failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an erroneous space, which can cause some softwares issues when receiving API key PM's as the invalid URL will not parse. (notably, this occurs in Fedify based implementations), as well as fixing an invalid syntax for Mentions in the mastodon PM implementation
Additionally, though unrelated to this PR specifically, the Mastodon PM proxy has become defunct with the retirement of botsin.space, and now reports a 401 error on any instance it's attempted on.