fix(screen): multiple small fixes in screen module behavior. #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedeDP
commented
Feb 25, 2023
| @@ -7,7 +7,7 @@ static void receive_waiting_state(const msg_t *msg, UNUSED const void *userdata) | |||
| static int parse_bus_reply(sd_bus_message *reply, const char *member, void *userdata); | |||
| static int get_screen_brightness(void); | |||
| static void timeout_callback(int old_val, bool reset); | |||
| static void pause_screen(bool pause, enum mod_pause type); | |||
| static void pause_screen(bool pause, enum mod_pause type, bool reset_screen_br); | |||
There was a problem hiding this comment.
Enforce the state.screen_br resetting when needed, even if screen was already paused.
Fix issues like:
- system going to sleep -> previous code skipped resetting screen br
- while system is sleeping, AC cable is disconnected -> since screen is already paused, screen_br is not resetted
FedeDP
commented
Feb 25, 2023
| get_screen_brightness(); | ||
| pause_screen(state.ambient_br < conf.bl_conf.shutter_threshold, CLOGGED, false); | ||
| if (!paused_state) { | ||
| get_screen_brightness(); |
There was a problem hiding this comment.
No need to get screen brightness if we are paused/clogged.
FedeDP
commented
Feb 25, 2023
| @@ -101,18 +103,18 @@ static void receive(const msg_t *msg, UNUSED const void *userdata) { | |||
| break; | |||
| } | |||
| case DISPLAY_UPD: | |||
| pause_screen(state.display_state, DISPLAY); | |||
| pause_screen(state.display_state, DISPLAY, false); | |||
There was a problem hiding this comment.
No need to reset screen_br on display upd (ie: dimming/dpms).
FedeDP
commented
Feb 25, 2023
| break; | ||
| case LID_UPD: | ||
| if (conf.bl_conf.pause_on_lid_closed) { | ||
| pause_screen(state.lid_state, LID); | ||
| pause_screen(state.lid_state, LID, false); |
There was a problem hiding this comment.
No need to reset screen_br on lid closed.
FedeDP
commented
Feb 25, 2023
| } | ||
| break; | ||
| case SUSPEND_UPD: | ||
| pause_screen(state.suspended, SUSPEND); | ||
| pause_screen(state.suspended, SUSPEND, false); |
There was a problem hiding this comment.
No need to reset screen_br on system suspend.
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
force-pushed
the
fix/screen_issues
branch
from
7580d52 to
0344540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.