Skip to content

fix: user.with_attr accepts any as value and auto convert to str #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: user.with_attr accepts any as value and auto convert to str #28

merged 1 commit into from
Aug 14, 2023

Conversation

hezean
Copy link
Contributor

@hezean hezean commented Aug 11, 2023

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #28 (47c6730) into main (ac77af4) will decrease coverage by 2.46%.
Report is 25 commits behind head on main.
The diff coverage is 68.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   85.64%   83.19%   -2.46%     
==========================================
  Files          34       38       +4     
  Lines        1247     1559     +312     
==========================================
+ Hits         1068     1297     +229     
- Misses        179      262      +83     
Files Changed Coverage Δ
featureprobe/internal/deprecated.py 0.00% <0.00%> (ø)
featureprobe/streaming_synchronizer.py 41.17% <41.17%> (ø)
featureprobe/realtime.py 48.14% <48.14%> (ø)
featureprobe/default_event_processor.py 80.88% <51.42%> (+6.48%) ⬆️
featureprobe/event.py 67.03% <61.19%> (-21.21%) ⬇️
featureprobe/data_repository.py 65.78% <66.66%> (+0.07%) ⬆️
featureprobe/synchronizer.py 68.00% <71.42%> (+1.33%) ⬆️
featureprobe/polling_synchronizer.py 87.71% <73.68%> (ø)
featureprobe/memory_data_repository.py 82.85% <75.00%> (+1.03%) ⬆️
featureprobe/client.py 84.00% <78.72%> (-10.88%) ⬇️
... and 10 more

... and 2 files with indirect coverage changes

@dengfeige dengfeige merged commit b0b1c96 into FeatureProbe:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Python 中 fp.User().with_attr('xxx', 0) 不能触发规则: if 数值 xxx = 0
2 participants