Skip to content

feat: support realtime toggle update via socket.io #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

feat: support realtime toggle update via socket.io #20

wants to merge 16 commits into from

Conversation

hezean
Copy link
Contributor

@hezean hezean commented Nov 29, 2022

realtime toggle update is not supported in python3.5, see miguelgrinberg/python-socketio#589

@SSebo
Copy link
Member

SSebo commented Nov 30, 2022

Good Job! You are so productive! BTW suggest to separate quotation mark replacement to another PR, to make this PR more focus on socketio part.

@FengShang
Copy link
Member

related to #19

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Merging #20 (b718a67) into main (ac77af4) will increase coverage by 0.29%.
The diff coverage is 71.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   85.64%   85.94%   +0.29%     
==========================================
  Files          34       36       +2     
  Lines        1247     1380     +133     
==========================================
+ Hits         1068     1186     +118     
- Misses        179      194      +15     
Impacted Files Coverage Δ
featureprobe/internal/deprecated.py 0.00% <0.00%> (ø)
featureprobe/memory_data_repository.py 81.81% <0.00%> (ø)
featureprobe/default_event_processor.py 82.17% <45.83%> (+7.77%) ⬆️
featureprobe/synchronizer.py 68.00% <71.42%> (+1.33%) ⬆️
featureprobe/client.py 85.24% <73.07%> (-9.63%) ⬇️
featureprobe/realtime.py 77.77% <77.77%> (ø)
featureprobe/pooling_synchronizer.py 86.74% <85.00%> (+10.27%) ⬆️
featureprobe/file_synchronizer.py 84.37% <88.88%> (+4.37%) ⬆️
featureprobe/user.py 91.66% <92.30%> (-1.44%) ⬇️
featureprobe/__init__.py 100.00% <100.00%> (ø)
... and 9 more

return None


def deprecated(*, since: str = None, successor=None):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used in this pr, but it may be used someday, so keep it?

@hezean hezean marked this pull request as ready for review December 4, 2022 15:27
@hezean hezean closed this Dec 26, 2022
@hezean hezean reopened this Dec 26, 2022
@hezean
Copy link
Contributor Author

hezean commented Dec 26, 2022

@dengfeige can we start reviewing this pr? it's functionally equivalent with FeatureProbe/server-sdk-node#6

@hezean
Copy link
Contributor Author

hezean commented Dec 26, 2022

ci crashed due to py3.5 not found, please help re-trigger it later, thanks

@gangb-tech
Copy link
Member

This PR has already been merged into #24.

@gangb-tech gangb-tech closed this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: python sdk integrate socketio client to receive realtime toggle update event
5 participants