-
Notifications
You must be signed in to change notification settings - Fork 2
feat: support realtime toggle update via socket.io #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Good Job! You are so productive! BTW suggest to separate quotation mark replacement to another PR, to make this PR more focus on socketio part. |
related to #19 |
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 85.64% 85.94% +0.29%
==========================================
Files 34 36 +2
Lines 1247 1380 +133
==========================================
+ Hits 1068 1186 +118
- Misses 179 194 +15
|
return None | ||
|
||
|
||
def deprecated(*, since: str = None, successor=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used in this pr, but it may be used someday, so keep it?
@dengfeige can we start reviewing this pr? it's functionally equivalent with FeatureProbe/server-sdk-node#6 |
ci crashed due to py3.5 not found, please help re-trigger it later, thanks |
This PR has already been merged into #24. |
realtime toggle update is not supported in python3.5, see miguelgrinberg/python-socketio#589