Skip to content

feat: Node.js SDK supports metric analysis #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Conversation

frankzhaopeng
Copy link
Member

@github-actions
Copy link
Contributor

Please adjust your PR title to match the Conventional Commits spec.

For example:

  • fix: fix http client code
  • feat: allow provided config object to extend other configs
  • refactor!: drop support for node 6
  • feat(ui): add button component

@frankzhaopeng frankzhaopeng changed the title ✨feat: Node.js SDK supports metric analysis feat: Node.js SDK supports metric analysis Mar 13, 2023
{ status: 200, body: '{' },
{ overwriteRoutes: true });

const recorder = new EventRecorder('sdk key', fakeEventUrl, 1000);

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "sdk key" is used as [authorization header](1).
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Merging #8 (5b4de01) into main (91fe718) will decrease coverage by 0.91%.
The diff coverage is 68.96%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   81.30%   80.39%   -0.91%     
==========================================
  Files           6        6              
  Lines         583      602      +19     
  Branches      108      114       +6     
==========================================
+ Hits          474      484      +10     
- Misses        108      117       +9     
  Partials        1        1              
Impacted Files Coverage Δ
src/FeatureProbe.ts 82.72% <44.44%> (-3.82%) ⬇️
src/Evaluate.ts 78.73% <66.66%> (-0.31%) ⬇️
src/Event.ts 82.85% <85.71%> (-0.65%) ⬇️

@frankzhaopeng frankzhaopeng merged commit c96eb35 into main Mar 13, 2023
@frankzhaopeng frankzhaopeng deleted the feat-track-event branch March 13, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨feat: Node.js SDK supports metric analysis
2 participants