Add update_predictor_exp function and its pytest function #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faye-yufan
reviewed
Jul 26, 2023
| @@ -335,3 +335,32 @@ def update_response_poly_categorical(self, predictor_name: str = None, betas: di | |||
| self.response_vector = numeric_vals[predictor_name] | |||
| else: | |||
| self.response_vector += numeric_vals[predictor_name] | |||
|
|
|||
| def update_predictor_exp(self, rate: float = None, | |||
| size: tuple = None, | |||
There was a problem hiding this comment.
Since the rest of the functions all use list or np.array as the input.
There was a problem hiding this comment.
Thanks for the feedback!
I was thinking about giving the option of defining output shape, e.g. multi-dimensional output. But I just realized that'd require a significant more complex function. We should indeed go with the simple version for now.
Also I think the size should be the number of observations by default. I will just get rid of this argument size for now.
Faye-yufan
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.