Skip to content

Commit

Permalink
Change expected name of registered module
Browse files Browse the repository at this point in the history
  • Loading branch information
dinomite committed Jun 15, 2021
1 parent e039696 commit 5a8ade6
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,6 @@ class DslTest {
assertTrue(mapper.isEnabled(JsonReadFeature.ALLOW_JAVA_COMMENTS))
assertFalse(mapper.isEnabled(JsonWriteFeature.QUOTE_FIELD_NAMES))
assertTrue(mapper.isEnabled(JsonReadFeature.ALLOW_SINGLE_QUOTES))
assertTrue(mapper.registeredModuleIds.any { it == "com.fasterxml.jackson.module.kotlin.KotlinModule" })
assertTrue(mapper.registeredModuleIds.any { it == "jackson-module-kotlin" })

This comment has been minimized.

Copy link
@dinomite

dinomite Jun 15, 2021

Author Member

@cowtowncoder A build failed for a no-code-changes commit, so I think it's due to a change in databind. It looks like the module names registered with the object mapper have changed from the full class name to…well I'm not actually sure where that string is coming from, the only code-ish place it's present is the pom. Is that intended?

This comment has been minimized.

Copy link
@cowtowncoder

cowtowncoder Jun 15, 2021

Member

Hmmh. Could be an earlier change, but more recently we had this:

FasterXML/jackson-databind#3110

which could be relevant. I think KotlinModule should probably give its full explicit name to constructor, and keep it same between 2.12 and 2.13 (no real upside).
But perhaps consider change for 3.0.

Having said that, I wasn't quite sure what should the "official" naming convention be.

This comment has been minimized.

Copy link
@dinomite

dinomite Jun 16, 2021

Author Member

Fixed in f8d7b31

This comment has been minimized.

Copy link
@cowtowncoder

cowtowncoder Jun 16, 2021

Member

I will also change the behavior of SimpleModule so this would work the way it was. The whole name-vs-module-registration-id is messy so I think backwards compatibility is important.

}
}

0 comments on commit 5a8ade6

Please sign in to comment.