InputData source not (yet?) supported for this format (Smile, CBOR)

[henrik-lindqvist]

Seems the createParser method of SmileFactory and CBORFactory is lacking implementation for java.io.DataInput sources.

[cowtowncoder]

Yes, this is correct. Due to time it took to add implementation for json backend, I had to postpone implementation for CBOR and Smile which would be the next likely cases (protobuf, alas, may be not supportable without external framing).

Would you be interested in using such input source if it was available? And if so, any preference order?

Note, too, that creating backend should be quite simple and mechanical.
However, I don't think it is doable by refactoring just because byte access is on critical path: that is, addition of nextByte() (or whatever) abstraction would be performance problem. This based on json implementation experiences.

[henrik-lindqvist]

No great importance. Glancing at the source, with little in-depth knowledge, i though it was a minor job, overriding a method. Simple workaround, using a DataInput to InputStream wrapper for now.

[cowtowncoder]

Ok. Mostly asking since I hope to gauge interest in yet-to-add/complete features, and if there's demand for InputData implementation I would consider it for implementation. There are so many things to potentially work on that I prefer working on things that seem more likely to be used and useful. :)

[henrik-lindqvist]

Focus on the more useful things! As said there's a simple workaround anyway.

[cowtowncoder]

@henrik-lindqvist :)

[leonard84]

Are there any plans to implement this? I just stumbled over this today.

[cowtowncoder]

@leonard84 I don't think anyone is working on this. Usually what happens is that people add a note on issue if they work on it.