Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TypeIdResolvers serializable for Jackson 2.16, with additional SimpleIdNameResolver #4305

Merged
merged 12 commits into from
Jan 7, 2024

Conversation

JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Jan 7, 2024

Blocked by #4304

This PR covers also SimpleNameIdResolver added since 2.16.

To be only draft, until #4304 be merged.

@JooHyukKim JooHyukKim closed this Jan 7, 2024
@JooHyukKim JooHyukKim deleted the 4303fix2.16 branch January 7, 2024 01:09
@JooHyukKim JooHyukKim restored the 4303fix2.16 branch January 7, 2024 01:09
@JooHyukKim JooHyukKim reopened this Jan 7, 2024
@JooHyukKim JooHyukKim changed the base branch from 2.17 to 2.16 January 7, 2024 01:11
@JooHyukKim JooHyukKim changed the title Make TypeIdResolvers serializable for Jackson 2.16 Make TypeIdResolvers serializable for Jackson 2.16, with additional SimpleIdNameResolver Jan 7, 2024
@JooHyukKim JooHyukKim changed the title Make TypeIdResolvers serializable for Jackson 2.16, with additional SimpleIdNameResolver Make TypeIdResolvers serializable for Jackson 2.16, with additional SimpleIdNameResolver Jan 7, 2024
@JooHyukKim JooHyukKim marked this pull request as draft January 7, 2024 01:43
@cowtowncoder
Copy link
Member

I am bit torn on whether this could/should go in 2.16 or not, as theoretically it changes observed API.

But I guess it's ok.

@JooHyukKim JooHyukKim marked this pull request as ready for review January 7, 2024 04:08
@cowtowncoder cowtowncoder merged commit cc6a1ae into FasterXML:2.16 Jan 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants