Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2592: JsonInclude support for any getters #2615

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

akhomchenko
Copy link
Contributor

Description

Fixes #2592

Fix will not work if filter is used as it triggers separate execution path. (see #testAnyGetterWithMapperDefaultIncludeNonEmptyAndFilterOnBean).

Notes

  • I've chosen 2.11 as target branch. I can move patch to a different one.

Fix will not work if filter is used as it triggers separate
execution path.
@cowtowncoder
Copy link
Member

Sounds good: I think 2.11 makes sense as there is non-trivial chance of regression (not saying I think there would be, just that these types of changes have higher risk), but also since I hope to get 2.11 out relatively soon.

One question: have I asked for a CLA yet? (can verify tonight from home)
If not, it would be here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and usual way is to print, fill & sign, scan or photo, email to info at fasterxml dot com.
If you already sent it earlier, no need to send again (one is enough for all contributions).

I hope to review the patch tonight, and with CLA be able to merge it I hope.

Thank you for the contribution!

@akhomchenko
Copy link
Contributor Author

I haven't signed CLA before. I've sent an email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants