Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate millis larger than 3 digits #1748

Merged
merged 4 commits into from
Aug 28, 2017
Merged

Conversation

brenuart
Copy link
Contributor

See #1745

@brenuart
Copy link
Contributor Author

Should we make the truncate behavior optional/configurable ?

@cowtowncoder
Copy link
Member

Oh shoot. Somehow I missed this PR -- my apologies. I fixed it along the same lines, of course, but would love to get tests merged (I added tests but much smaller).

As to behavior: I'd be fine leaving it as is for now. As with other aspects (colon or no colon for time zone offset), adding method(s) for creating new instances with different configuration would be fine. But I am not sure I see clear need yet.

@brenuart
Copy link
Contributor Author

I merged master back into this branch. The only changes left now are those related to the tests. You can safely merge the PR and you'll get the updated test case.

@cowtowncoder cowtowncoder merged commit 4cd4140 into FasterXML:master Aug 28, 2017
@brenuart brenuart deleted the gh1745 branch September 1, 2017 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants