Jackson exceptions should be Jackson-serializable #1370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add @JsonIgnore to JsonMappingException
Original form of test did not assert that the first attempt to serialize should cause a JsonMappingException
Renders JsonMappingException Jackson-serializable
|
Thank you for the test & fix: used both, but merged separately just to apply to 2.7 branch (i'm sure git has a way to merge it to different base but my git-fu is weak). So closing just because of separate commit. Fix will be in 2.7.8 / 2.8.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a quick fix and regression test for this issue. I leave it up to the official maintainers to decide if the coverage is accurate and of course encourage you to squash my far-too-numerous commits if you do decide to merge this change in.