Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error-handling for java.net.URL deserialization #1353

Closed
cowtowncoder opened this issue Aug 31, 2016 · 2 comments
Closed

Improve error-handling for java.net.URL deserialization #1353

cowtowncoder opened this issue Aug 31, 2016 · 2 comments
Milestone
2.8.3

Comments

@cowtowncoder
Copy link
Member

(for background see dropwizard/dropwizard#1647)

Currently exception from construction of java.net.URI is not explictly handled but bubbles up and probably ends in generic wrapper, instead of more semantically meaningful message.
We should handle that explicitly to handle it better, to allow for more graceful handling at higher level.
cowtowncoder added a commit that referenced this issue Aug 31, 2016
@cowtowncoder
Trying to reproduce #1353, not succeeding
f08748f
@cowtowncoder
Copy link
Member Author

Looks like failure with an invalid URI (like one containing space character) does throw InvalidFormatException as expected.

@cowtowncoder cowtowncoder reopened this Aug 31, 2016
@cowtowncoder
Copy link
Member Author

Ah! But handling of java.net.URL did NOT catch it -- fixing.

@cowtowncoder cowtowncoder changed the title Improve error-handling for java.net.URI deserialization Improve error-handling for java.net.URL deserialization Aug 31, 2016
@cowtowncoder cowtowncoder added this to the 2.8.3 milestone Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.3
Development

No branches or pull requests
1 participant
@cowtowncoder