Minor reordering of code

FasterXML · May 31, 2020 · 5cfeba0 · 5cfeba0
1 parent 9729aae
commit 5cfeba0
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 22 deletions.
diff --git a/src/main/java/com/fasterxml/jackson/databind/deser/std/EnumMapDeserializer.java b/src/main/java/com/fasterxml/jackson/databind/deser/std/EnumMapDeserializer.java
@@ -242,16 +242,16 @@ public EnumMap<?,?> deserialize(JsonParser p, DeserializationContext ctxt)
         }
         // Ok: must point to START_OBJECT
         JsonToken t = p.currentToken();
-        if ((t != JsonToken.START_OBJECT) && (t != JsonToken.FIELD_NAME) && (t != JsonToken.END_OBJECT)) {
-            // (empty) String may be ok however; or single-String-arg ctor
-            if (t == JsonToken.VALUE_STRING) {
-                return (EnumMap<?,?>) _valueInstantiator.createFromString(ctxt, p.getText());
-            }
-            // slightly redundant (since String was passed above), but also handles empty array case:
-            return _deserializeFromEmpty(p, ctxt);
+        if ((t == JsonToken.START_OBJECT) || (t == JsonToken.FIELD_NAME)
+                || (t == JsonToken.END_OBJECT)) {
+            return deserialize(p, ctxt, constructMap(ctxt));
+        }
+        // (empty) String may be ok however; or single-String-arg ctor
+        if (t == JsonToken.VALUE_STRING) {
+            return (EnumMap<?,?>) _valueInstantiator.createFromString(ctxt, p.getText());
         }
-        EnumMap result = constructMap(ctxt);
-        return deserialize(p, ctxt, result);
+        // slightly redundant (since String was passed above), but also handles empty array case:
+        return _deserializeFromEmpty(p, ctxt);
     }
 
     @Override

diff --git a/src/main/java/com/fasterxml/jackson/databind/deser/std/MapDeserializer.java b/src/main/java/com/fasterxml/jackson/databind/deser/std/MapDeserializer.java
@@ -357,21 +357,23 @@ public Map<Object,Object> deserialize(JsonParser p, DeserializationContext ctxt)
         }
         // Ok: must point to START_OBJECT, FIELD_NAME or END_OBJECT
         JsonToken t = p.currentToken();
-        if (t != JsonToken.START_OBJECT && t != JsonToken.FIELD_NAME && t != JsonToken.END_OBJECT) {
-            // (empty) String may be ok however; or single-String-arg ctor
-            if (t == JsonToken.VALUE_STRING) {
-                return (Map<Object,Object>) _valueInstantiator.createFromString(ctxt, p.getText());
+        if ((t == JsonToken.START_OBJECT) || (t == JsonToken.FIELD_NAME)
+                || (t == JsonToken.END_OBJECT)) {
+            final Map<Object,Object> result = (Map<Object,Object>) _valueInstantiator.createUsingDefault(ctxt);
+            if (_standardStringKey) {
+                _readAndBindStringKeyMap(p, ctxt, result);
+                return result;
             }
-            // slightly redundant (since String was passed above), but also handles empty array case:
-            return _deserializeFromEmpty(p, ctxt);
-        }
-        final Map<Object,Object> result = (Map<Object,Object>) _valueInstantiator.createUsingDefault(ctxt);
-        if (_standardStringKey) {
-            _readAndBindStringKeyMap(p, ctxt, result);
+            _readAndBind(p, ctxt, result);
             return result;
         }
-        _readAndBind(p, ctxt, result);
-        return result;
+
+        // (empty) String may be ok however; or single-String-arg ctor
+        if (t == JsonToken.VALUE_STRING) {
+            return (Map<Object,Object>) _valueInstantiator.createFromString(ctxt, p.getText());
+        }
+        // slightly redundant (since String was passed above), but also handles empty array case:
+        return _deserializeFromEmpty(p, ctxt);
     }
 
     @SuppressWarnings("unchecked")

diff --git a/src/main/java/com/fasterxml/jackson/databind/deser/std/NullifyingDeserializer.java b/src/main/java/com/fasterxml/jackson/databind/deser/std/NullifyingDeserializer.java
@@ -5,7 +5,6 @@
 import com.fasterxml.jackson.core.*;
 import com.fasterxml.jackson.databind.*;
 import com.fasterxml.jackson.databind.jsontype.TypeDeserializer;
-import com.fasterxml.jackson.databind.type.LogicalType;
 
 /**
  * Bogus deserializer that will simply skip all content there is to map