Fix hot reloading module state bug #813
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FasterSpeeding
commented
Aug 15, 2023
| except Exception as exc: | ||
| self._call_loaders(module_path, old_loaders) | ||
| modules_dict.pop(module_path) |
There was a problem hiding this comment.
failed module load could have a variant with a field which indicates whether it reverted or not
FasterSpeeding
commented
Aug 15, 2023
CHANGELOG.md
Outdated
| @@ -14,6 +14,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - [BasicLocaliser.set_variants][tanjun.dependencies.BasicLocaliser.set_variants] | |||
| now tries to normalise the locale keys of variants passed as keyword arguments | |||
| to match the [hikari.Locale][hikari.locales.Locale] values. | |||
| - The hot-reloader no-longer reverts to a module's old components loaded after | |||
There was a problem hiding this comment.
both reloader and the reload method*
FasterSpeeding
force-pushed
the
bugfix/reloading
branch
from
79c572c
to
ee8d1bd
Compare
FasterSpeeding
force-pushed
the
bugfix/reloading
branch
from
ee8d1bd
to
faceed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
noxand all the pipelines have passed.Related issues