-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a thin veneer of compatibility with mypy #166
Merged
FasterSpeeding
merged 12 commits into
FasterSpeeding:master
from
A5rocks:mypy-compatibility
Jan 2, 2022
Merged
Add a thin veneer of compatibility with mypy #166
FasterSpeeding
merged 12 commits into
FasterSpeeding:master
from
A5rocks:mypy-compatibility
Jan 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A5rocks
commented
Nov 24, 2021
Decided it was better to get this done and over with rather than waiting on some mypy PRs to be merged in |
Other than those two things, looks good to me |
FasterSpeeding
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
;3
The rest of the errors seem to fall under python/mypy#11605 and python/mypy#5374.
Checklist
nox
and all the pipelines have passed.Related issues
idk I did this for no reason at all