Skip to content

Commit

Permalink
Fix issues building with node 22 (#14)
Browse files Browse the repository at this point in the history
NAPI include was masking a missing include which prevented it building
  • Loading branch information
TrentHouliston authored Jul 29, 2024
1 parent cfbcfc0 commit bce2671
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/formatting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: '20.x'
node-version: '22.x'
cache: 'yarn'

- run: yarn install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
node-version: [18.x, 20.x, 21.x]
node-version: [18.x, 20.x, 22.x]

steps:
- name: Checkout Code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-to-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '22.x'
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nbsdecoder.js",
"version": "0.4.4",
"version": "0.4.5",
"description": "Node.js module for interacting with NUClear Binary Stream files",
"main": "nbsdecoder.js",
"types": "nbsdecoder.d.ts",
Expand Down
3 changes: 2 additions & 1 deletion src/Hash.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@

#include "Hash.hpp"

#include <stdexcept>

namespace nbs {

namespace hash {
Expand Down
1 change: 1 addition & 0 deletions src/Hash.hpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#ifndef HASH_HPP
#define HASH_HPP

#include <cstdint>
#include <napi.h>

#include "third-party/xxhash/xxhash.h"
Expand Down

0 comments on commit bce2671

Please sign in to comment.