Fix various typos in the codebase #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found via `codespell -q 3 -S *.ts -L alo,groupd,groupe,mapp,nd,ro,ue`
Yes, this is a given. Anytime strings are touched translations of said string are marked as pending translation. |
|
Hi @luzpaz, Please create an issue that describes the changes that you've made, then associate this PR with that issue. |
luzpaz
changed the title
|
@slspencer ☝️ |
|
.>Yes, this is a given. Anytime strings are touched translations of said
string are marked as pending translation.
Not sure what that means? If you change a tr(string) or <string> in a ui
file that is set to translate, and there are any translations, they no
longer will be loaded as the string they are supposed to replace is gone.
Point being, maybe the 1/2 dozen or so translations that could be rendered
void are more important than the 1 slightly misspelled English source
string?
That being said, I took a quick look at some of the ui strings, and they
are probably not translated anyhow as I would suspect that they would have
shown up with the switch *.ts.
But... The fact that the spelling was done en masse, a bunch of the
example pattern files were mucked up that are using custom increments ,
that yes happen to have mis spellings, but they probably need to stay that
way to work.
This is one reason why we prefer creating issues... In looking at a created
issue I could have said don't just correct all the spelling en masse
without knowing the application.
…On Wed, Aug 31, 2022, 12:59 PM Susan Spencer ***@***.***> wrote:
Hi @luzpaz <https://github.com/luzpaz>, Please create an issue that
describes the changes that you've made, then associate this PR with that
issue.
Thanks! -S
—
Reply to this email directly, view it on GitHub
<#672 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHTXADVQULJJCTR25DXAXFTV36FPRANCNFSM6AAAAAAQAI7TLI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I can revert whatever you want. so let me know |
|
Please advise |
|
I've created a new branch to test the typos and if they affect the GUI |
slspencer
approved these changes
Sep 5, 2022
|
Diaglogs affected:
|
|
Heads up, #674 was never closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via
codespell -q 3 -S *.ts -L alo,groupd,groupe,mapp,nd,ro,ue