This repository was archived by the owner on Jul 7, 2026. It is now read-only.
3.2.39.3への更新と一部のファイルの更新 - #43
Merged
Merged
Conversation
- expression context is not enough
- don't need multiple prepare steps - try to use git output for SHA and log message
- Although unique_ptr is only used when ICU is enabled, include it always because it is likely that we'll use more unique_ptr in the implementation at some point.
The popup now cuts down messages to a manageable length.
Hopefully the part that is preserved, will still show
something meaningful for the user (8 lines of text should
be sufficient for the kind of things we do).
FIXES #1613
…, preserve newlines
- while here, nudge CalamaresUtils automount API a little, since it doesn't really need an rvalue-ref.
- make the tools tab buttons along the bottom row - show the global storage tab by default This costs little screen real-estate, makes the tools much more visible and useful.
- offer a convenience method for showing a popup and URL information and copying the URL to the clipboard - use that from ViewManager (on failure) and DebugWindow (on demand)
- mention the *packages* service in CHANGES for the previous release
Typo
In 4ffa79d, the spelling was changed to consistently be "autoLoginUser" in the *users* module, but that changed the Global Storage key as well, and the *displaymanager* module wasn't changed to follow.
The machinery in `setConfigurationMap()` was just duplicating
checks already in place in the `getString()` and `getBool()`
methods, and there's no special need for efficiency here,
so prefer the more readable and short code.
("efficiency" here means "we're saving one method call in
case the configuration is not set")
When loading the lists, no initial string-value was being
set for the model, layout and variant; the configuration
could pass right through and pick up empty strings instead.
If the user does not change the model, the UI would show
"pc105" but the internal setting would still be empty.
FIXES #1668
The code path for setting the locale / language automatically
emits currentLanguageStatusChanged(), but the code that updates
GS connects to currentLanguageCodeChaged(). This was altered in
the 3.2.28 release cycle. Since then, automcatic locale selection
wasn't setting *locale* in GS, so that a click-through kind of
locale selection would not set it; then the packages module
has no *locale* setting for localization packages.
The combination of status and code signals (machine- and human-
readable) is ok. Introduce a setter to the language that does
the necessary signalling, so that setting the language automatically
also DTRT.
FIXES #1671
- four possibilities for old and new keys - 6e is the check for not-actually-set, to track defaults
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calamares.desktopをAlterISO用に変更final-processを最新のものに更新