This repository was archived by the owner on Jul 7, 2026. It is now read-only.
Updated 3.2.35.1 - #39
Merged
Merged
Conversation
- Remove code that is duplicated in Config. - Hook up UI for physical keyboard model, and back. - For now, introduce some named slots with debugging output. This makes debugging a lot easier since we have function names to work with rather than anonymous lambdas
- Use the just-refactored XKBListModel to store the xkb key-value pairs for variants, drop most of the complicated implementation, store just a single list of values.
- With debugging and untangling done, the lambdas are simple and short, so return to using them. One point of improvement might be to give the models suitable slots themselves, to avoid even this indirection.
This lands Artem's work on supporting non-ASCII layouts better,
which currently only applies to Russian layouts -- it works with
a table, so it is easy to extend for other layouts.
The QML and Widget steps now completely share the Config backend,
which is why there's so many commits here: the Widget page needed
to have most of its code ripped out, and the models for
keyboard data were broken in various ways and needed fixing.
FIXES #1211
FIXES #1556
The translation happens whenever this code is run, which may not match the language the user subsequently selects. It also causes general problems with the translation, since we end up with a possibly-partly-translated name.
- The method addEntry with PartitionEntry appears to be unused since its always. Drop it!
- The constructor PartitionLayout with PartitionEntry appears to be unused since its always. Drop it!
- The logic of the method initLayout belongs to the object PartitionLayout. Move logic to that object. - Use a single method initLayout in object PartitionCoreModule. - Member m_partLayout in object PartitionCoreModule is no longer allocated.
- The variant helper getString() calls contains() already.
These methods don't touch anything in the class, and are more safely tucked away as static (TU-local) free functions.
The QLatin1String() might be replaced by char[], that trades one initialization for two but with a simpler data section; this probably is not worth profiling.
"Generic support" and "Known Issues" links fixed
[branding] Welcome Page links
The .35 release was really on 2020-12-04, but I'm not going to go back and update that date.
Merge upstream
…buggy and asks for password even when it is not needed
Don't use plymouth-encrypt if there is keyfile in use, because it is buggy and asks for password even when it is not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.