This repository was archived by the owner on Jul 7, 2026. It is now read-only.
Calamares v3.2.28.2 and Supported AlterISO2 and 3 - #34
Merged
Conversation
- getLocationPosition doesn't need to be a method, since it calls out to a static function of TimeZoneImageList anyway.
- The models are constant pointers, even if their contents aren't. - Make the top-level (region) model point to the global TZ list.
- since Config knows what settings there are, it should create the jobs to run later -- not the Page. - this doesn't work yet, because the Config does **not** know what the selected timezone is yet.
- setting the initial location is something the Config-object should do - setting up the combo-boxes can be done in the constructor
- several early-return paths would leave the TZ widget blocked - use the zones data from config
- expand API documentation - minor coding-style adjustments
- the language and LC settings migrate from page to config - add API for explicitly setting language (which is then preserved when clicking new locations)
- configuration information lives in the Config object
- the config knows the status and how to describe it, fetch the strings from there.
- remove the weirdly-structured prettyStatus and similar: the Config object has human-readable status strings (three, for location, language, and LC-formats) which can be normal properties with signals. - Implement prettyStatus in the view step by querying the Config.
- since all locale changes need to be entered into GS anyway, this is something the Config object can do because it is the source of truth for locale settings. - drop all the GS settings from the Page.
- allow finer-grained control over whether-or-not to adjust the timezone in the live system. - handle some special cases at the point of loading-configuration. - document the setting in locale.conf - correct some documentation bugs - adjust the YAML schema for locale.conf so it's legal YAML syntax **and** validates the current file.
- writing *localeConf* settings to GS can be done always when the formats are set, rather than special-cased. The code that handles the "special case" of no widget existing for the ViewStep overlooks the other crashes that happen then. - Since Config knows what jobs to create, just ask it rather than keeping a copy.
- read the *region* and *zone* settings; this duplicates what the ViewStep does and is currently unused, but .. - add new support for using the system's TZ (rather than the fixed values from *region* and *zone*). This complements GeoIP lookup. This is the actual feature that started the long rewrite of the Config object (so that all the business logic would be in one place, usable for both widgets and QML). FIXES calamares#1381
- this doesn't do the lookup **yet** - while here, refactor setConfigurationMap so it reads like a story, with chunks bitten out into a handful of static inline void methods.
- replace the weird synchronous-lookup-during-requirements-checking with a proper async lookup when the system is ready.
- since the Page hooked up a model and changed the region-selection **after** connecting to signals, it would reset the location to Africa/Abijan (alphabetically the first timezone) during construction. Don't do that.
- add apidox to all the untranslatedFS() methods - add the most-basic of untranslatedFS(), which works on a given FileSystem::Type; this one can handle special cases where Cala needs a different untranslated name than what KPMCore provides.
Special case reiserfs (named "reiserfs" in /etc/fstab and as
a `mount -t` argument).
FIXES #1479
- this makes is much easier to double-click-select the directory, since the . isn't attached and won't be selected along with the directory anymore.
- Qt 5.11 and early 5.12 just don't support Esperanto at all
- QStringList doesn't round-trip correctly; add a test to demonstrate that. - Fix existing test to **not** use QStringList, but QVariantList (of strings), which is how other code would use it. The above is **kind** of moot because nothing uses the YAML-save function, but it might. While here, fix another test: YAML-loading can load JSON just fine.
- the scripts are BSD-2-clause, - the generated files are CC0 (I'm not *100%* sure about the derived file CountryData_p.cpp, which lists countries and country codes -- it **is** extracted from CLDR data which is not CC0)
- This is kind of bogus, since the file has existed for much longer than the identifier says, but I don't want to do spelunking now.
- was getting multiple definitions of moc-related code due to automoc combined with KDSAG having its own #include moc, comment-out the include. - while here, simplify the CMake bits for building KDSAG
- need to add the job to the list rather than just leaking it
[welcomeq] language bar icon configurable
FIXES #1483
- 26b8c82 added the list of all-the-groups-for-the-user, but didn't change the list passed to the method that creates groups. FIXES #1488
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.