remove playwright install from workflows

Farooq-Mirza · Oct 4, 2023 · d44b9e9 · d44b9e9
1 parent ab1db26
commit d44b9e9
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 16 deletions.
diff --git a/.github/workflows/e2e-full.yml b/.github/workflows/e2e-full.yml
@@ -25,9 +25,8 @@ jobs:
           node-version: 20
 
       - name: Install
-        run: |
-          npm ci 
-          npx playwright install
+        run: npm ci 
+
 
       - name: Test
         env:

diff --git a/.github/workflows/e2e-smoke.yml b/.github/workflows/e2e-smoke.yml
@@ -25,9 +25,7 @@ jobs:
           node-version: 20
 
       - name: Install
-        run: |
-          npm ci 
-          npx playwright install
+        run: npm ci 
 
       - name: Test
         env:

diff --git a/.github/workflows/pull.yml b/.github/workflows/pull.yml
@@ -161,9 +161,7 @@ jobs:
           node-version: 20
 
       - name: Install
-        run: |
-          npm ci 
-          npx playwright install
+        run: npm ci 
 
       - name: Test
         env:
@@ -191,9 +189,7 @@ jobs:
           node-version: 20.5.1
 
       - name: Install
-        run: |
-          npm ci 
-          npx playwright install
+        run: npm ci
 
       - name: start openfin
         run: npm run _e2e:openfin:run --manifest_url=https://openfin.env.reactivetrader.com/pull/${{ github.event.number }}/config/rt-fx.json
@@ -223,9 +219,7 @@ jobs:
           node-version: 20.5.1
 
       - name: Install
-        run: |
-          npm ci 
-          npx playwright install
+        run: npm ci
 
       - name: start openfin
         run: npm run _e2e:openfin:run --manifest_url=https://openfin.env.reactivetrader.com/pull/${{ github.event.number }}/config/rt-credit.json

diff --git a/packages/client/playwright.config.ts b/packages/client/playwright.config.ts
@@ -10,7 +10,8 @@ const config: PlaywrightTestConfig = {
     {
       name: "chrome",
       use: {
-        ...devices["Desktop Chrome"],
+        ...devices["Desktop Chrome"], 
+        channel: 'chrome',
         //Artifacts
         screenshot: "only-on-failure",
         video: "retain-on-failure",