Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) #2287 fixed multiline textinput does not grow anymore #2323

Merged
merged 1 commit into from
Jan 17, 2023
Merged

(fix) #2287 fixed multiline textinput does not grow anymore #2323

merged 1 commit into from
Jan 17, 2023

Conversation

flodev
Copy link
Contributor

@flodev flodev commented Dec 29, 2022

Hi,
this is a bugfix for multiline textinputs not growing anymore described in here #2287

Don't hesitate to contact if you need more information.

I would be pleased if someone could merge it.

best regards flo

@flodev flodev mentioned this pull request Dec 29, 2022
Closed
@flodev
Copy link
Contributor Author

flodev commented Dec 30, 2022

hm after thoroughly testing I've found an issue that'll cause infinite flickering on iOS. I need to dig into this again.

@flodev
Copy link
Contributor Author

flodev commented Dec 30, 2022

Hi there, so I changed the callbacks and replaced the onLayout with onContentSizeChange.
Now growing of the textinput works same as in version 0.16.3
Now I know someone changed it for a reason and I'm keen to know if the onLayout should still be there and what it initially was for?

@tbergeron
Copy link

When can we expect a new release including this change?

@gontovnik
Copy link

@Johan-dutoit hey! Could we please create 1.1.1 with the following fix? :)

@Johan-dutoit
Copy link
Collaborator

I'll get this tested ASAP

@Johan-dutoit Johan-dutoit linked an issue Jan 17, 2023 that may be closed by this pull request
Multiline does not grow TextInput. The toolbar / composer height is always fixed. #2287
Closed
@Johan-dutoit Johan-dutoit merged commit 8539294 into FaridSafi:master Jan 17, 2023
@Johan-dutoit
Copy link
Collaborator

FYI this was released in v1.1.1

@tbergeron tbergeron mentioned this pull request Mar 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johan-dutoit Johan-dutoit Johan-dutoit approved these changes

@Arch1tect Arch1tect Arch1tect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiline does not grow TextInput. The toolbar / composer height is always fixed.
5 participants
@flodev @tbergeron @gontovnik @Johan-dutoit @Arch1tect