Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unwanted scroll to bottom on message change #1472

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Fix unwanted scroll to bottom on message change #1472

merged 2 commits into from
Oct 16, 2019

Conversation

amiralies
Copy link
Contributor

Closes #1447

@amiralies
Copy link
Contributor Author

@xcarpentier I didn't find any case that it will be useful (maybe when user sends a message ?), but i think we should do this with a prop later sth like scrollToBottomOnMessageChange.

@xcarpentier
Copy link
Collaborator

when inverted is false

@amiralies
Copy link
Contributor Author

@xcarpentier added that though i think inverted={false} is quite unstable and we should make it more stable.
btw can we release this change?

@xcarpentier
Copy link
Collaborator

yep

@xcarpentier xcarpentier merged commit 83d66c9 into FaridSafi:master Oct 16, 2019
@antoinefotso antoinefotso mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading earlier messages should keep ListView at same scroll position
2 participants
@amiralies @xcarpentier