feat: change revoke and assign behavior to turn on/off the trigger #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinhonovais
requested review from
carlosgoias,
Daniel-C-Dias,
luispfgarces,
jdromeiro,
jorgedgodinho,
sergioamribeiro,
spookylsm,
rodrigobelo,
fernando-a-marins and
brunohfgomes
jdromeiro
requested changes
Jul 21, 2022
src/KafkaFlow.Retry.UnitTests/KafkaFlow.Retry/Durable/Polling/QueueTrackerTests.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.Retry.UnitTests/KafkaFlow.Retry/Durable/Polling/QueueTrackerTests.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.Retry.UnitTests/KafkaFlow.Retry/Durable/Polling/QueueTrackerTests.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.Retry.UnitTests/KafkaFlow.Retry/Durable/Polling/QueueTrackerTests.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.Retry.UnitTests/KafkaFlow.Retry/Durable/Polling/QueueTrackerTests.cs
Outdated
Show resolved
Hide resolved
jdromeiro
requested changes
Jul 21, 2022
src/KafkaFlow.Retry.UnitTests/KafkaFlow.Retry/Durable/Polling/QueueTrackerCoordinatorTests.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.Retry.UnitTests/KafkaFlow.Retry/Durable/Polling/QueueTrackerCoordinatorTests.cs
Show resolved
Hide resolved
jdromeiro
previously approved these changes
Jul 22, 2022
carlosgoias
previously approved these changes
Jul 22, 2022
spookylsm
previously approved these changes
Aug 3, 2022
sergioamribeiro
previously approved these changes
Aug 10, 2022
martinhonovais
dismissed stale reviews from sergioamribeiro, spookylsm, carlosgoias, and jdromeiro
via
1ff5d71
martinhonovais
force-pushed
the
quartz_shutdown_problems
branch
from
1ff5d71
to
b6ec085
Compare
carlosgoias
approved these changes
Oct 17, 2022
brunohfgomes
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The revoke partition was stopping all quartz jobs because we were shutting down the quartz. This pull request changed that behavior to just schedule or unschedule the jobs.
Fixes #76
Fixes #91
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement