feat: delete queues cleanup #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-a-marins
force-pushed
the
feat/18/retention_policy
branch
from
1b95716
to
35f68b7
Compare
carlosgoias
previously approved these changes
Feb 17, 2023
src/KafkaFlow.Retry/Durable/Polling/Jobs/CleanupJobDataProvider.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.Retry/Durable/Repository/Actions/Delete/DeleteQueuesInput.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.Retry/Durable/Repository/Actions/Delete/DeleteQueuesResult.cs
Outdated
Show resolved
Hide resolved
luispfgarces
requested changes
Feb 21, 2023
samples/KafkaFlow.Retry.Sample/Helpers/KafkaClusterConfigurationBuilderHelper.cs
Show resolved
Hide resolved
src/KafkaFlow.Retry/Durable/Definitions/Builders/Polling/PollingDefinitionBuilder.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.Retry/Durable/Definitions/Builders/Polling/PollingDefinitionsAggregatorBuilder.cs
Show resolved
Hide resolved
src/KafkaFlow.Retry/Durable/Definitions/Builders/Polling/PollingDefinitionsAggregatorBuilder.cs
Show resolved
Hide resolved
src/KafkaFlow.Retry/Durable/Definitions/Builders/Polling/PollingDefinitionsAggregatorBuilder.cs
Show resolved
Hide resolved
src/KafkaFlow.Retry/Durable/Polling/Jobs/RetryDurablePollingJob.cs
Outdated
Show resolved
Hide resolved
martinhonovais
previously approved these changes
Feb 22, 2023
luispfgarces
requested changes
Feb 24, 2023
src/KafkaFlow.Retry/Durable/Definitions/Builders/Polling/PollingDefinitionsAggregatorBuilder.cs
Show resolved
Hide resolved
...KafkaFlow.Retry/Durable/Definitions/Builders/Polling/RetryDurablePollingDefinitionBuilder.cs
Show resolved
Hide resolved
luispfgarces
approved these changes
Feb 28, 2023
martinhonovais
approved these changes
Mar 1, 2023
fernando-a-marins
added a commit
that referenced
this pull request
Jun 16, 2023
This reverts commit 86daad2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a retention policy for all queues and messages
Fixes #18
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement