Preserve timestamps for existing destination directories #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copying or moving directories with "Preserve all timestamps" enabled, timestamps are restored only for newly created destination directories. If the destination directory already exists, its timestamps are currently left unchanged, even when it corresponds to a source directory being copied. This breaks the expected behavior of the option. Queue existing destination directories for timestamp restoration in the same way as newly created ones, so their timestamps are restored after copy completion. Fixes FarGroup#460
|
Author
|
On the new Sonar Cloud's issue: the additional nesting already exists and this change adds no new structural complexity and keeps the behavior local and explicit. |
Contributor
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When copying or moving directories with "Preserve all timestamps" enabled, timestamps are restored only for newly created destination directories.
If the destination directory already exists, its timestamps are currently left unchanged, even when it corresponds to a source directory being copied. This breaks the expected behavior of the option.
Queue existing destination directories for timestamp restoration in the same way as newly created ones, so their timestamps are restored after copy completion.
References
Fixes #460