-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavior of Shift+F7 and Alt+F7 in Viewer and Editor #600
Comments
So what exactly the new behavior should be? |
That is correct. The current behavior is especially vexing in a situation when I was tracking something for some time jumping back and forth multiple times with |
It is confusing indeed. I also never use the checkbox and either press enter and then Alt+F7 or jump to the beginning before searching. I'm not a big fan of new far:config options though, maybe we can do it without them? A couple of alternative solutions:
|
Of the two solutions, I certainly prefer the latter, with two buttons. Auto-clearing Let me finish Text / Hex controls on the standard search dialog, then I will implement By the way, how about something like this:
with the hotkeys |
I'd probably prefer the latter too as more obvious.
This probably will be unreadable with raster fonts (yes, there are people who still use them for some reason). |
Ugh! The words it is! Less hassle implementing non-standard behavior. |
I'm definitely for this solution. And plain words are better than fancy symbols as words are easier to communicate to another person. To avoid the up/down metaphor, we might use the forward/backward pair. |
This is definitely more user-friendly, and similar to how it's implemented in other editors, like Visual Studio. |
@alabuzhev, assign this one to me please. |
Also, on the Search / Replace dialog, replaced "Reverse" checkbox with "Search Down / Up" buttons.
Also, on the Search / Replace dialog, replaced "Reverse" checkbox with "Search Down / Up" buttons.
Also, on the Search / Replace dialog, replaced "Reverse" checkbox with "Search Down / Up" buttons.
… (down or up respectfully) instead of reversing the direction defined by the last invocation of the Search / Replace dialog. Also, on the dialog itself, replaced "Reverse" checkbox with "Search Down / Up" buttons.
… (down or up respectfully) instead of reversing the direction defined by the last invocation of the Search / Replace dialog. Also, on the dialog itself, replaced "Reverse" checkbox with "Search Down / Up" buttons.
… (down or up respectfully) instead of reversing the direction defined by the last invocation of the Search / Replace dialog. Also, on the dialog itself, replaced "Reverse" checkbox with "Search Down / Up" buttons.
… (down or up respectfully) instead of reversing the direction defined by the last invocation of the Search / Replace dialog. Also, on the dialog itself, replaced "Reverse" checkbox with "Search Down / Up" buttons.
… (down or up respectfully) instead of reversing the direction defined by the last invocation of the Search / Replace dialog. Also, on the dialog itself, replaced "Reverse" checkbox with "Search Down / Up" buttons.
… (down or up respectfully) instead of reversing the direction defined by the last invocation of the Search / Replace dialog. Also, on the dialog itself, replaced "Reverse" checkbox with "Search Down / Up" buttons.
… (down or up respectfully) instead of reversing the direction defined by the last invocation of the Search / Replace dialog. Also, on the dialog itself, replaced "Reverse" checkbox with "Search Down / Up" buttons.
gh-600: Shift+F7 and Alt+F7 now search in absolute directions
Description of the new feature or improvement
Currently, the search direction of Shift+F7 and Alt+F7 depends on the "Reverse search" option of the Search dialog, viz.
Somehow, this behavior confuses me to no end. In fact, because of this behavior, I never check "Reverse search" checkbox in the dialog, and use Shift+F7 and Alt+F7 hotkeys as if they search in the absolute direction, no matter the dialog option:
This effectively means that if I want to search backward, towards the beginning of the file, I open the dialog, leave "Reverse search" checkbox unchecked, press "Enter" and as soon as the next pattern is found, press Alt+F7 to find the previous pattern. I then proceed pressing Alt+F7 if I want to continue searching.
I would like to have a global "far:config" parameter controlling this behavior. By default (
false
), the current behavior is used. If the parameter is set totrue
, the new behavior is activated. The parameter could be called something like "SearchContinueAbsoluteDirection".Proposed technical implementation details (optional)
Though Editor / Viewer search implementation is a bit tricky, I think I can do this feature. Any objections?
The text was updated successfully, but these errors were encountered: