Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Lachesis type refactoring (don't merge) #8

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

b-scholz
Copy link
Collaborator

@b-scholz b-scholz commented Dec 4, 2024

The Lachesis does not carefully differentiate between concepts (e.g., an event can be a hash, ID, or object) and uses package names to differentiate them. The concepts are defined in various directories. This attempts to place consensus objects into a single package called types (NB: I could not use types because of name conflicts with Ethereum in the Sonic client).

The necessary changes to the client are shown here:
https://github.com/Fantom-foundation/Sonic/compare/b-scholz/lachesis-type-refactoring?expand=1

@b-scholz b-scholz added the enhancement New feature or request label Dec 4, 2024
@b-scholz b-scholz changed the title Lachesis type refactoring WIP: Lachesis type refactoring (don't merge) Dec 4, 2024
@b-scholz
Copy link
Collaborator Author

b-scholz commented Dec 5, 2024

The following symbols are used from the ltypes package:

ArrayToValidators
BaseEvent
BeginBlockFn
BlockCallbacks
BlockID
BytesToBlockID
BytesToEvent
BytesToHash
BytesToLamport
Cheaters
Consensus
ConsensusCallbacks
EpochID
Event
EventHash
EventHashes
EventID
FakeEvent
FakeEvents
FakeHash
FrameID
FromBytes
GetNodeName
Hash
HexToEventHash
HexToHash
Lamport
MaxLamport
Metric
MutableBaseEvent
NewBigBuilder
NewBuilder
Of
OrderedEventHashes
SetEventName
ValidatorID
ValidatorIdx
Validators
Weight
Zero
ZeroEvent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant