Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accidentally committed fuzzing test data #789

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

HerbertJordan
Copy link
Collaborator

This data was accidentally added by #784.

@LuisPH3
Copy link
Contributor

LuisPH3 commented Sep 21, 2024

I don't dislike this data, in addition to fast-forwarding the fuzzing corpus set to more sensible inputs, it will be run as normal unit tests with each test run, serving as a regression.
It is true that it is a cryptic, maybe a readme file in the folder explaining where do they come from.

@HerbertJordan HerbertJordan marked this pull request as ready for review September 27, 2024 08:50
@HerbertJordan HerbertJordan force-pushed the herbert/remove_fuzzer_test_data branch 2 times, most recently from 8febb13 to c269943 Compare September 27, 2024 09:36
@LuisPH3 LuisPH3 self-requested a review October 9, 2024 06:58
Copy link
Contributor

@LuisPH3 LuisPH3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although these files serve as unit tests against regressions, I don't think these are issues we must guard against and can be safely deleted.

@LuisPH3 LuisPH3 force-pushed the herbert/remove_fuzzer_test_data branch from c269943 to 0bc1471 Compare October 9, 2024 07:40
@LuisPH3 LuisPH3 force-pushed the herbert/remove_fuzzer_test_data branch from 0bc1471 to 380b902 Compare October 9, 2024 07:59
@LuisPH3 LuisPH3 merged commit d5951f8 into main Oct 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants