LFVM: set and setByte test
#759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuMH
force-pushed
the
facundo/lfvm-setbyte
branch
2 times, most recently
from
d57c1ce
to
d86f2be
Compare
facuMH
force-pushed
the
facundo/lfvm-setbyte
branch
2 times, most recently
from
93f29c5
to
277d3ce
Compare
LuisPH3
previously approved these changes
Sep 12, 2024
facuMH
force-pushed
the
facundo/lfvm-setbyte
branch
from
277d3ce
to
d44c174
Compare
facuMH
force-pushed
the
facundo/lfvm-setbyte
branch
from
d44c174
to
46ae2df
Compare
facuMH
force-pushed
the
facundo/lfvm-setbyte
branch
from
4109226
to
9768f6f
Compare
Merged
facuMH
requested review from
HerbertJordan,
LuisPH3 and
simonlechner
and removed request for
simonlechner,
LuisPH3 and
HerbertJordan
facuMH
force-pushed
the
facundo/lfvm-setbyte
branch
from
179646b
to
181c71b
Compare
facuMH
requested review from
HerbertJordan,
simonlechner and
LuisPH3
and removed request for
HerbertJordan
HerbertJordan
previously approved these changes
Sep 27, 2024
facuMH
force-pushed
the
facundo/lfvm-setbyte
branch
from
c130f3d
to
2b3cb29
Compare
facuMH
force-pushed
the
facundo/lfvm-setbyte
branch
from
2b3cb29
to
df244c7
Compare
…814) * Improve memory's set implementation and associated unit tests * fix linter issues --------- Co-authored-by: facuMH <facumolina15@gmail.com>
facuMH
force-pushed
the
facundo/lfvm-setbyte
branch
from
df244c7
to
f278c54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of PRs that aim to make private and improve the memory methods.
In this PR:
SetByteandSetWordare now private functions.Setfunctions is removed since we are moving towards enforcing that memory can not attempt to read/write without expanding first.SetWithCapacityAndGasCheckis renamed toset, simplified to simply callgetSlicefrom LFVM: CopyWord and GetSlice* test #761 and then copy from input value to the slice.setByteandsetWordis implemented as a specialization ofsetWithCapacityAndGasCheck.set,setByteandsetWord.This is part of #682
This PR will rework set to be a specialization+copy of
getSlicefrom #761