Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test QoL] Suppress Verbose Log #237

Closed
wants to merge 4 commits into from

Conversation

rpl-ffl
Copy link
Collaborator

@rpl-ffl rpl-ffl commented Aug 12, 2024

Current the following test TestLogsIntegrationGetRealMetric, TestCanCollectCpuProfileDateFromOperaNode are expected to print the following lines:

2024/08/12 16:11:04 monitoring: failed to parse log: Get "node1/debug/metrics/prometheus": unsupported protocol scheme ""
2024/08/12 16:11:04 monitoring: failed to parse log: Get "http://localhost:33541/debug/metrics/prometheus": dial tcp 127.0.0.1:33541: connect: connection refused
2024/08/12 16:11:21 closing prometheus log parser
2024/08/12 16:11:21 prometheus log parser closed

While expected, these lines can clutter up the log during CI/CD at best and cause confusion at worst.
In response, an optional SuppressVerboseLog function is added to suppress the logs.

As agreed, print a warning instead of suppress the log.

@rpl-ffl
Copy link
Collaborator Author

rpl-ffl commented Aug 12, 2024

#207

@rpl-ffl rpl-ffl closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant