generated from readthedocs/tutorial-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
57 changing the cluster conn function to use domain nameshostnames instead of ips #58
Open
MuhammadQadora
wants to merge
29
commits into
main
Choose a base branch
from
57-changing-the-cluster_conn-function-to-use-domain-nameshostnames-instead-of-ips
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
534723e
changed Cluster_Conn to use hostnames instead of ips
MuhammadQadora eff9ae8
changed redis version to use master until new release
MuhammadQadora 3fd5c14
changed redis dependency to point to Dudi's branch
MuhammadQadora e5cfe80
for testing
MuhammadQadora 377fae2
lowered retries
MuhammadQadora eef67b8
updated retry times
MuhammadQadora e65ee26
lowered retries
MuhammadQadora 97bbe4a
insane retry count
MuhammadQadora 0e79477
changed dependenct to debug
MuhammadQadora 98719f6
reduced retry count
MuhammadQadora f65ce34
updated dependency
MuhammadQadora f623557
updated retry attempts
MuhammadQadora 427ef70
Update falkordb.py
MuhammadQadora 523ff53
Update cluster.py
MuhammadQadora 8509151
Update pyproject.toml
MuhammadQadora 09c969a
Update cluster.py
MuhammadQadora da45121
Update falkordb.py
MuhammadQadora 14580bc
changed dependenc
MuhammadQadora ac39f29
Merge branch '57-changing-the-cluster_conn-function-to-use-domain-nam…
MuhammadQadora c074f70
Update falkordb.py
MuhammadQadora adbbada
Update cluster.py
MuhammadQadora 670e908
changed dependenc
MuhammadQadora af46b2b
Merge branch '57-changing-the-cluster_conn-function-to-use-domain-nam…
MuhammadQadora d795189
Update falkordb.py
MuhammadQadora d05f644
Update falkordb.py
MuhammadQadora 343f0c0
Update falkordb.py
MuhammadQadora a43db2e
Update falkordb.py
MuhammadQadora 674c651
Update falkordb.py
MuhammadQadora 4c485b4
Update falkordb.py
MuhammadQadora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enhancements and Concerns in
Cluster_Conn
FunctionThe modifications to
Cluster_Conn
function are well-aligned with the PR objectives, transitioning from IP-based to hostname-based connections. The use ofCLUSTER NODES
to dynamically retrieve node information and the implementation of a retry mechanism are significant improvements.However, as indicated by static analysis tools and previous comments, these changes are not covered by unit tests. It is crucial to ensure that new functionalities work as expected and do not introduce regressions.
Would you like me to help by generating the unit testing code or opening a GitHub issue to track this task?
Tools
GitHub Check: codecov/patch