Skip to content

Commit 7aadd68

Browse files
authored
fix(types): exclude queryKey / queryFn from options if they have been provided as a separate argument (TanStack#2689)
1 parent 9edbd67 commit 7aadd68

File tree

3 files changed

+38
-17
lines changed

3 files changed

+38
-17
lines changed

src/react/useInfiniteQuery.ts

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,15 @@ export function useInfiniteQuery<
2828
TQueryKey extends QueryKey = QueryKey
2929
>(
3030
queryKey: TQueryKey,
31-
options?: UseInfiniteQueryOptions<
32-
TQueryFnData,
33-
TError,
34-
TData,
35-
TQueryFnData,
36-
TQueryKey
31+
options?: Omit<
32+
UseInfiniteQueryOptions<
33+
TQueryFnData,
34+
TError,
35+
TData,
36+
TQueryFnData,
37+
TQueryKey
38+
>,
39+
'queryKey'
3740
>
3841
): UseInfiniteQueryResult<TData, TError>
3942
export function useInfiniteQuery<
@@ -44,12 +47,15 @@ export function useInfiniteQuery<
4447
>(
4548
queryKey: TQueryKey,
4649
queryFn: QueryFunction<TQueryFnData, TQueryKey>,
47-
options?: UseInfiniteQueryOptions<
48-
TQueryFnData,
49-
TError,
50-
TData,
51-
TQueryFnData,
52-
TQueryKey
50+
options?: Omit<
51+
UseInfiniteQueryOptions<
52+
TQueryFnData,
53+
TError,
54+
TData,
55+
TQueryFnData,
56+
TQueryKey
57+
>,
58+
'queryKey' | 'queryFn'
5359
>
5460
): UseInfiniteQueryResult<TData, TError>
5561
export function useInfiniteQuery<

src/react/useMutation.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@ export function useMutation<
2929
TContext = unknown
3030
>(
3131
mutationFn: MutationFunction<TData, TVariables>,
32-
options?: UseMutationOptions<TData, TError, TVariables, TContext>
32+
options?: Omit<
33+
UseMutationOptions<TData, TError, TVariables, TContext>,
34+
'mutationFn'
35+
>
3336
): UseMutationResult<TData, TError, TVariables, TContext>
3437
export function useMutation<
3538
TData = unknown,
@@ -38,7 +41,10 @@ export function useMutation<
3841
TContext = unknown
3942
>(
4043
mutationKey: MutationKey,
41-
options?: UseMutationOptions<TData, TError, TVariables, TContext>
44+
options?: Omit<
45+
UseMutationOptions<TData, TError, TVariables, TContext>,
46+
'mutationKey'
47+
>
4248
): UseMutationResult<TData, TError, TVariables, TContext>
4349
export function useMutation<
4450
TData = unknown,
@@ -48,7 +54,10 @@ export function useMutation<
4854
>(
4955
mutationKey: MutationKey,
5056
mutationFn?: MutationFunction<TData, TVariables>,
51-
options?: UseMutationOptions<TData, TError, TVariables, TContext>
57+
options?: Omit<
58+
UseMutationOptions<TData, TError, TVariables, TContext>,
59+
'mutationKey' | 'mutationFn'
60+
>
5261
): UseMutationResult<TData, TError, TVariables, TContext>
5362
export function useMutation<
5463
TData = unknown,

src/react/useQuery.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ export function useQuery<
2121
TQueryKey extends QueryKey = QueryKey
2222
>(
2323
queryKey: TQueryKey,
24-
options?: UseQueryOptions<TQueryFnData, TError, TData, TQueryKey>
24+
options?: Omit<
25+
UseQueryOptions<TQueryFnData, TError, TData, TQueryKey>,
26+
'queryKey'
27+
>
2528
): UseQueryResult<TData, TError>
2629
export function useQuery<
2730
TQueryFnData = unknown,
@@ -31,7 +34,10 @@ export function useQuery<
3134
>(
3235
queryKey: TQueryKey,
3336
queryFn: QueryFunction<TQueryFnData, TQueryKey>,
34-
options?: UseQueryOptions<TQueryFnData, TError, TData, TQueryKey>
37+
options?: Omit<
38+
UseQueryOptions<TQueryFnData, TError, TData, TQueryKey>,
39+
'queryKey' | 'queryFn'
40+
>
3541
): UseQueryResult<TData, TError>
3642
export function useQuery<
3743
TQueryFnData,

0 commit comments

Comments
 (0)