fix(types): exclude queryKey / queryFn from options if they have been provided as a separate argument #2689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… provided as a separate argument
when using the overloaded version with multiple arguments, passing the same value inside options doesn't have any effect and is ignored at runtime, e.g.: `useQuery(key, fetchIt, { queryKey: 'foo' })`. With this fix, we disallow that on type level
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/A2htxAFpRLafnHmDqMvwqGz4PsMQ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit faf65d4:
|
Member
|
🎉 This PR is included in version 3.24.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using the overloaded version with multiple arguments, passing the same value inside options doesn't have any effect and is ignored at runtime, e.g.:
useQuery(key, fetchIt, { queryKey: 'foo' }). With this fix, we disallow that on type levelcloses #2647