Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not use deprecated MT_RAND_PHP constant on PHP 8.3 #845

Open
wants to merge 4 commits into
base: 2.0
Choose a base branch
from

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Jan 2, 2024

What is the reason for this PR?

  • requires tests to pass on PHP 8.3
  • stops using the deprecated MT_RAND_PHP constant on PHP 8.3
  • skips tests failing on PHP 8.3 when running on PHP 8.3 and above

Follows #844.

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are added to the CHANGELOG.md
  • Changes are approved by maintainer

@localheinz localheinz self-assigned this Jan 2, 2024
@localheinz localheinz changed the title Fix: Require tests on PHP 8.3 to pass Fix: Do not use deprecated MT_RAND_PHP constant on PHP 8.3 Jan 2, 2024
@localheinz localheinz added the bug Something isn't working label Jan 2, 2024
@localheinz localheinz assigned pimjansen and bram-pkg and unassigned localheinz Jan 2, 2024
@localheinz localheinz marked this pull request as ready for review January 2, 2024 14:03
Copy link

stale bot commented Mar 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lifecycle/stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants