-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add safeIpv4 and safeIpv6 #831
base: 2.0
Are you sure you want to change the base?
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
I think the issue is valid as proposed. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
Still a neat feature suggestion. Having real IPs in test data is not a great pattern really. |
Define "real" ip addresses. For each usecase there is something to be said. If you want it strict you would need to manually provide the cidr ranges which means it gets too complex as well. And it that case its more like a 1.1.1.1 till 255.255.255.255 as well |
Real in contrast to them provided in this helper which are defined as for documentation purposes. And I understand the problem changing the default into the documentation IPs and so on, that hasn't been proposed (yet). |
What is the reason for this PR?
Add the posibility to generate "safe" documentation IP addresses:
Author's checklist
Summary of changes
Added two new methods:
safeIpv4
safeIpv6
Review checklist
CHANGELOG.md