Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lets ignore phpstorm idea folder since it is irritating #28

Closed
wants to merge 1 commit into from

Conversation

pimjansen
Copy link
Contributor

Lets ignore it since it is just annoying as hell :)

@pimjansen pimjansen requested a review from bram-pkg January 18, 2023 16:56
@@ -2,3 +2,4 @@
/vendor
/vendor-bin
/composer.lock
/.idea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also work though i expect not many ppl to use it dont you think?

Copy link
Member

@bram-pkg bram-pkg Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do, cause it should never be committed. Contains db credentials, etc.

I don't believe we should have this kind of IDE-specific references here.
Then we should add Fleet, VS Code, Sublime, etc.

@pimjansen pimjansen closed this Jan 18, 2023
@pimjansen pimjansen deleted the feature/idea branch January 18, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants