Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshake Slider #14812

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jade-Harleyy
Copy link

Pretty much what the title says.
The game is much nicer to play when you can actually see and select the correct objects.

New Localization

ScreenShake: Screenshake

@Regalis11
Copy link
Collaborator

Regalis11 commented Oct 15, 2024

The game is much nicer to play when you can actually see and select the correct objects.

To me this seems like an underlying issue that should be addressed, rather than allowing the shake to be disabled entirely. If there's situations in which the shaking is too strong or lasts too long, those could be adjusted for example. The way the shaking works could also be adjusted: rather than moving the camera, it could alter the rotation and/or zoom it, so the things near the center of the screen would be moved less.

Allowing this to be disabled entirely feels like a band-aid solution to the issue, and it can cause other kinds of issues. The screen shake is an important piece of feedback in some situations - have you gone through all of the cases in which it's used and evaluated that there's still enough feedback with the shake removed?

@Regalis11 Regalis11 added Feature request Request a new feature to be added Code Programming task Waiting Cannot be worked on/reviewed/tested at the moment for some reason labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Programming task Feature request Request a new feature to be added Waiting Cannot be worked on/reviewed/tested at the moment for some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants