[pull] main from chromium:main #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This test assumes both features are enabled, and especially that fixed more is enabled - without it, these tests are flaky depending on host device. Fixed: 1277441 Change-Id: I11b453c3f2f6ad66a6c7ccf8ae72afa7de9cd325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323990 Reviewed-by: Travis Skare <skare@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/main@{#949798}
This metric will allow us to determine the click through rate of the omnibox icon, as well as the "automatic open" rate. Bug: 1269628 Change-Id: Id1efd6eb8bc089933b87911bbc518b2bbf955fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317003 Reviewed-by: Maggie Cai <mxcai@chromium.org> Auto-Submit: Tim Sergeant <tsergeant@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/main@{#949799}
The "Change default" modal dialog had various elements that were dark mode compliant but ensure it is completely dark mode compliant. Before Light: http://shortn/_NEw30h1dk4 Before Dark: http://shortn/_Z77GBTP3Fb After Light: http://shortn/_PxSOXSCoVY After Dark: http://shortn/_kQQKyGmpsb Bug: 1250594 Test: Deploy chrome and visually inspect Change-Id: Ic3cb30d2e4e1a73dfd09f1fbd016ad59bfed7dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3316996 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/main@{#949800}
This reverts commit 8acb8d8. Reason for revert: Tentative fix for CrOS bots Original change's description: > Only filter out subsettings with lower scores. > > The launcher settings search currently filters out all sub-settings or > sub-sections which contain an ancestor in the results page. This is > sometimes bad because the specific setting is actually the desired > result (see the crbug for an example). > > This CL changes filtering so that only sub-settings with an equal or > worse score than their ancestor get filtered out. > > Tested on device with some common queries to check that results are > still good. > > Bug: 1267815 > Change-Id: Id9935295cb4731a9cf1af6121c08568648331e8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320655 > Reviewed-by: Tony Yeoman <tby@chromium.org> > Commit-Queue: Rachel Wong <wrong@chromium.org> > Cr-Commit-Position: refs/heads/main@{#949385} Bug: 1267815 Change-Id: I56f681dd924d924a811faa2310cc24e9d1fd901a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325294 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/main@{#949801}
Roll Chrome Win64 PGO profile from chrome-win64-main-1638975444-336691a69f954ff560514f94e1b6d15d096843b5.profdata to chrome-win64-main-1638997181-a0f2b7a8d601f1546ca540a6d84ebc0757124df4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6337ff7d4a8dc172db300c9473b65dd7060de69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324293 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#949802}
Bug: 1273132 Change-Id: I4867e7d6db620bc92a136402c8536ed51b26e5a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324644 Reviewed-by: Derek Schuff <dschuff@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: David Bertoni <dbertoni@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/main@{#949803}
Persists range request offsets to InProgressInfo and proto db. Bug: 1255769 Change-Id: Ie7f04794eb7004a249528de40228886b85532de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322260 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/main@{#949804}
Changed all instances of "WebApplicationShortcutsMenuItemInfo" to "WebAppShortcutsMenuItemInfo" Bug: 1091473 Change-Id: Id22874de8d402c3944ea2d0fb8e4084405c42886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320653 Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Alexander Bolodurin <alexbn@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Reviewed-by: Jiewei Qian <qjw@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Anosua Roy <anosua@google.com> Cr-Commit-Position: refs/heads/main@{#949805}
This reverts commit 9666a97. Reason for revert: Causing crashes. See https://bugs.chromium.org/p/chromium/issues/detail?id=1277884 Original change's description: > Read data from TfLite model file off thread > > While classification happens off-thread, the process of reading from > the model file and passing the model data between threads can still > impact the main thread. > > Since a trivial TfLite model file does not cause any regression in > Largest Contentful Paint, we speculate that this time is the root > cause of the regression. > > Bug: 1277600 > Change-Id: I4bfe5d21bc3141e5101d449a00ce4549ca1c424e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321309 > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/main@{#949141} Bug: 1277600 Change-Id: Id443ca5aa850c44db1b48d0b12fe34a3b624c000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324702 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/main@{#949806}
This CL adds all the HRESULTs defined in MFerror.h (in Windows Kits\10\Include\10.0.19041.0\um\Mferror.h) since we are enabling Media Foundation-based playback for both encrypted and clear contents. Bug: 1267332 Change-Id: Iecd3700a0c354d8bf41a714474b0dd974da9a088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324564 Reviewed-by: John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#949807}
A few new values were created in the code version of these enums but not reflected in their UMA versions. Change-Id: I0bcfbe9012a176cadfeeec599a6685cb15956ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324412 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/main@{#949808}
https://screenshot.googleplex.com/6c2SbCB4unfX2GW Bug: b/205769218 Test: Manually Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I668134f209ffceda182361aa03165ef265c1e8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323746 Reviewed-by: Jeffrey Young <cowmoo@chromium.org> Commit-Queue: Jason Thai <jasontt@chromium.org> Cr-Commit-Position: refs/heads/main@{#949809}
Change-Id: I0fbf5119631e8f5c69bb5e051b6df730b52fe9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324648 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#949810}
In a recent Jank investigation around ShoppingPersistedTabData#deserialize I noticed we try to deserialize when there is no persisted data acquired from storage. We should simply skip over #deserialize in this case which is signaled by hasRemaining() being 0 in the ByteBuffer acquired from Persisted storage. Bug: 1277685 Change-Id: I2ada76ab1e8b38b96de7f5f82ba61f740a823825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319793 Reviewed-by: Ayman Almadhoun <ayman@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/main@{#949811}
This experiment is now on by default after crrev.com/c/3318590. And crrev.com/c/3321235 removed any reference to it in the recipe. So the experiment should no longer need to be set to have the recipe use results from RDB. Bug: 1135718 Change-Id: I2f08915847318937764f4c1fae9abafcfc7de08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323743 Reviewed-by: Garrett Beaty <gbeaty@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/main@{#949812}
Bug: 1187025, 1187061, 1187028 Change-Id: I06fe277c6f42ed8f4224207e0ab1c8d15afa47fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320690 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#949813}
Bug: 1187061 Change-Id: I555da04e3538ed169188282c0224b193ae42570e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320917 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#949814}
…est.cc Bug: 1187061 Change-Id: I2fd256e9572cfd44c7ac171acf18206463006829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320920 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#949815}
Bug: 1187061 Change-Id: Ide91d765572a12708963449d91e5f1cf6171231e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322517 Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#949816}
Bug: 1187061, 1187025, 1187028 Change-Id: If8f6b3a0292e17caac2fe719163fb20ac44feac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321062 Reviewed-by: Charles Reis <creis@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#949817}
Bug: 1187061, 1187025, 1187028 Change-Id: I67fd2c567429ba23da7acd040047a2767a134340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320780 Reviewed-by: Charles Reis <creis@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#949818}
This change updates the device operation handler to assume that forgetting a device will be successful. This avoids the scenario where we successfully forget a device, but are never notified that it was forgotten since the device was removed and unable to notify us. Recording: https://drive.google.com/file/d/1-wxlyfX6qmll_TPK3G3oQw7rdpx5w7_w/view?usp=sharing Fixed: b/209076810 Test: Manually on device and CQ try-jobs. Change-Id: Ib32d273e944ac5bcf9f9cd8335fdd05daf8a5cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324682 Reviewed-by: Gordon Seto <gordonseto@google.com> Commit-Queue: Chad Duffin <chadduffin@chromium.org> Cr-Commit-Position: refs/heads/main@{#949819}
Bug: 1187061, 1187025, 1187028 Change-Id: I56229a27352cc60b174d04a0817a2019d0806f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322492 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#949820}
Changes: - omit unnecessary object class. - python2 superclass call. - omit unnecessary superclass calls. - removed obsoleted pylint flags. - reraised exceptions to use from. - fixed python2 methods to python3. Bug: 1262303 Change-Id: I079955a43aa4a0632493a25e8db4b01a2028417d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313767 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/main@{#949821}
Roll Chrome Win32 PGO profile from chrome-win32-main-1638986360-007651e391bc80b4eefd0805c96788200d0402f5.profdata to chrome-win32-main-1638997181-ca84cfe7d0f664974bdd99579b5a7c63c3944f76.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4f76b4beff424278b6ca09cb18e84f4048e2d00f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324294 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#949822}
This directory must be readable by the crosvm process, so we set it with 755 permissions. This emulates the behaviour of the default socket, which has 755 permissions when it is created by login_manager. Bug: b/200896773 Change-Id: Ie41d69daa0d2ec22aa3a67bfea103ffd7638125a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319220 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/main@{#949823}
Bug: 1273132 Change-Id: Ic0abfb7e3553d14532f997a75dc5d83acf0f21b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324642 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#949824}
This patch calls CalculateBreakAppealBefore to determine the correct appeal to pass into MovePastBreakpoint. This allows correct support for deciding when to violate a orphans/widows constraint vs. a break-before:avoid. etc. Bug: 614667 Change-Id: I7a8ee8329dd9458bb62af063ba9df20459e88e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322020 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#949825}
There is a data race between the concurrent scanner and the mutator: 1) scanner calls memory::RemaskPtr() (which is __arm_mte_get_tag()) and retrieves the tagged pointer to the scannable area; 2) mutator increments the tag concurrently (i.e. frees the slot); 3) scanner dereferences the pointer to the scannable area, but the tag is already old. This CL disables MTE while scanning is in progress. We could disable MTE checks only once in scanner thread, but that wouldn't work for safepoints. It could also hide potential bugs in *Scan. Calling __arm_mte_get_tag() is anyway too expensive for every single word (or 16 bytes, which is the minimal granularity). Bug: 1277560, 1249550 Change-Id: Iec89e9bddf6bea810361e8c909e9db4487fb5c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320265 Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#949826}
Bug: 1245834 Change-Id: Id95a02ec2fcff4777e0963bef5cfc56435513c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321297 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#949827}
This CL makes sure the HID device physical_device_id is set only when kIOHIDLocationIDKey is not 0 to avoid "Keyboard Backlight" device and "TouchBarUserDevice" device to be unique on macOS. Change-Id: Iad200df53d01f8a6a7773477d0030fafd65da5a7 Bug: 1276032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314562 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/main@{#949884}
No intended behavior change. Bug: 1273132 Change-Id: Id46a05bd280e7c8c078e542229029dcbd086f281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323696 Reviewed-by: Sam Clegg <sbc@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#949885}
…::Job::DoInitConnectionImplQuic Change-Id: If1e9beb524d791fbb68c523bc5c8db676bfb9b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324578 Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by: David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/main@{#949886}
Bug: N/A Change-Id: I6cc1365f166e86138c4f5f4b2ab46b0b4fbf4f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324370 Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by: Aishwarya Rajesh <aishwaryarj@google.com> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/main@{#949887}
https://skia.googlesource.com/skia.git/+log/c307c5566d11..d2eb1d90b3b9 2021-12-08 jcgregorio@google.com Remove wacky-yuv tests from iPhone6. 2021-12-08 johnstiles@google.com Sort GM/sample slides in Viewer. 2021-12-08 johnstiles@google.com Migrate SK_strcasecmp to SkStringUtils.h. 2021-12-08 johnstiles@google.com Fix source repetition in debug traces. 2021-12-08 jvanverth@google.com [graphite] Set up depth/stencil attachment 2021-12-08 herb@google.com don't produce empty slugs! If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1277583 Tbr: jmbetancourt@google.com Change-Id: I73d9ad9da2f9028250a7c0108ec96abae4af52a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324843 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#949888}
jkardatzke@ is now doing other things BUG=None TEST=None Change-Id: I4ca8a16563d9dc01343941eee964732665146193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2993454 Reviewed-by: J Kardatzke <jkardatzke@chromium.org> Reviewed-by: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by: Josh Horwich <jhorwich@chromium.org> Commit-Queue: Lloyd Pique <lpique@chromium.org> Cr-Commit-Position: refs/heads/main@{#949889}
This CL splits handwriting wpt tests into two parts: * The part that requires a mocked handwriting interface * The part that doesn't require the mock So the second part can be upstreamed to wpt repo. Change-Id: I8e3f28d71cf9c7243cd8040cf8e73fee98ee28d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325323 Reviewed-by: Glen Robertson <glenrob@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#949890}
Preview recordings available in crbug.com/1261249#c2 Bug: 1261249 Change-Id: I0da4358b72ce675ddb061173f83aaba173005377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322269 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Sinan Sahin <sinansahin@google.com> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/main@{#949891}
When hiding the grid, there were certain cases where the overview windows were not able to be restored by the FocusController due to the focus being set on the incorrect window/widget. This CL follows the previous convention of activating the overview focus window, which is what is expected when entering overview mode in the beginning. Fixed: 1275176 Test: manual, added Change-Id: I3be8d4049a3abc230b5313fdb7e0a81deac34425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314280 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Richard Chui <richui@chromium.org> Cr-Commit-Position: refs/heads/main@{#949892}
On start surface and tab switcher, #wasShown can be called by the webcontents of selected tabs, which leads to activate navigation scope by mistake. Use onWebContentsFocused/LostFocused to determine if the current webContents is user interactable or fully visible. Bug: 1275714 Change-Id: I79262026d453f22a57ac8c2b2b2faa93bba54263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324701 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/main@{#949893}
Still used for evaluation of power improvements/interventions. Change-Id: I6504cb649e849280637f364a3b653034cbfd77d0 Fixed: 1258750 Fixed: 1258751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323052 Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by: Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/main@{#949894}
This patch removes GraphicsLayer from PaintArtifactCompositor. Bug: 1277748 Change-Id: I017aa35eb00798cbcd70b998fc2384cea8c09a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324743 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#949895}
This change includes: - Move the image container's custom padding in NotificationViewBase to NotificationView so that this would not affect the new notification. - Add top padding to image container and action buttons row, making the space between these views are 16px. Bug: 1268168 Change-Id: I92a12886104c0d3b64f2d3c9488c633a185c6c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321913 Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/main@{#949896}
Roll Chrome Win64 PGO profile from chrome-win64-main-1638997181-a0f2b7a8d601f1546ca540a6d84ebc0757124df4.profdata to chrome-win64-main-1639007967-ae5d7efc50363224ac6b0fac1f8e68f3ea1508e4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic7879c45949fa4913b621ac3820a4648666a4168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325087 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#949897}
The configuration option 'arm_control_flow_integrity' allows to build Chromium and deps with support for both PAC (Pointer Authentication Code) and BTI (Branch Target Identification). This change will allow to enable PAC independently from BTI. Bug: 919548 Change-Id: I0a2f15cbe2f3f55c1e27979bb5ef10cf88ad940c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324882 Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/main@{#949898}
Bug: 1278145 Change-Id: I1369aa03c54df4a3b54a4042d53da05d4b6193f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325581 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by: Will Harris <wfh@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/main@{#949899}
Add a histogram to record the mime type of the data being copied. Also, move the other metrics to be further along the code journey, so they don't get recorded prematurely (like recorded and then we do an early exit instead of showing the bubble). Bug: 1244143 Change-Id: Ibf060f7a08d2f4b709a963787ad36171be5fcb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320689 Reviewed-by: Weilun Shi <sweilun@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/main@{#949900}
https://chromium.googlesource.com/catapult.git/+log/fcd455d2e403..d16203a89ed9 2021-12-08 fdegans@google.com [code-health] Run common/py_utils/PRESUBMIT.py under Python 3 2021-12-08 fdegans@google.com [code-health] Run devil/PRESUBMIT.py under Python 3 2021-12-08 fdegans@google.com [code-health] Update protobuf python library in gae_ts_mon 2021-12-08 yuhengh@chromium.org Reland "Fix telemetry.internal.browser.tab_unittest.TabTest.testTabIsAlive is flaky" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1246005,chromium:1262294,chromium:942720 Tbr: eseckler@google.com Change-Id: Ib14c217cbfbd42bf1815b5ce1e7cd1198882e60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324292 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#949901}
Fixed: 1259557 Change-Id: Ib8d7639b4c200a92336ff6a9f9a80c0560162dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223127 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/main@{#949902}
This is a reland of 8acb8d8 The original CL was reverted due to suspected Tast failures, but it was not the culprit. See https://bugs.chromium.org/p/chromium/issues/detail?id=1278130#c7. Original change's description: > Only filter out subsettings with lower scores. > > The launcher settings search currently filters out all sub-settings or > sub-sections which contain an ancestor in the results page. This is > sometimes bad because the specific setting is actually the desired > result (see the crbug for an example). > > This CL changes filtering so that only sub-settings with an equal or > worse score than their ancestor get filtered out. > > Tested on device with some common queries to check that results are > still good. > > Bug: 1267815 > Change-Id: Id9935295cb4731a9cf1af6121c08568648331e8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320655 > Reviewed-by: Tony Yeoman <tby@chromium.org> > Commit-Queue: Rachel Wong <wrong@chromium.org> > Cr-Commit-Position: refs/heads/main@{#949385} Bug: 1267815 Change-Id: Iaf01b6296550773b45d7b46e1e110406f6f804e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325325 Reviewed-by: Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/main@{#949903}
This CL adds logging to help debug sensor subscription issues. Bug: 1258104 Change-Id: I3c32cf69f520aa67d79ce210c895db910a1a400d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293534 Reviewed-by: Chris Mumford <cmumford@google.com> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/main@{#949904}
This removes NonSFI support from launcher code. BUG=b/200965779,1273132 TEST=Ran tryjob. Change-Id: I0344381e5020096bf7f059201e8ddaa12b0b4adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320776 Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by: Derek Schuff <dschuff@chromium.org> Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/main@{#949905}
The median and variance statistics are added for normalized percent dropped metrics of ukm. Bug: chromium:1276516 Change-Id: Ia66ec7ca31ab4efab872383341263e7726ddcce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315466 Reviewed-by: Nicolás Peña <npm@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/main@{#949906}
Given that we already have a callback_relevant_script_state_, it's better to use its GetContext() than calling into a V8 API GetCreationContextChecked() because it's faster. This patch also mitigates a crash issue of 1275805. Since we won't call GetCreationContextChecked() with this patch, chrome won't crash. Having said that, the root cause might be memory corruption somewhere else. Bug: 1275805 Change-Id: Ibe79c6deeddf742d0dbb6ec020bbb85a1d45548c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323621 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/main@{#949907}
This CL will add skew tests for version 97.0.4692.48. See crbug.com/1041619 and crbug.com/1099017 for more information. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I58ed0279200b7c72c27a844c91808751c24cd112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325762 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#949908}
crrev.com/c/3276295 disabled this test to fix the loading page issue on a fenced frame. The CL re-enables the test after it has been verified. Bug: 1269931 Change-Id: Ie495e35ffbcca1625e5399ff834d31c86b70785f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301209 Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/main@{#949909}
https://swiftshader.googlesource.com/SwiftShader.git/+log/a4232c15e287..d4130e9ac367 2021-12-08 capn@google.com Refactor active blend factor determination 2021-12-08 capn@google.com Refactor active blend operation determination 2021-12-08 capn@google.com Fix passthrough blend operations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-eng+autoroll@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-eng+autoroll@google.com Change-Id: I01834fc6de8f7dcc2b8823b5d75fd3f88e017379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325381 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#949910}
This reverts commit dabe981. Reason for revert: https://crbug.com/1278177 Original change's description: > system-extensions: Add system-extensions-internals > > chrome://system-extensions-internals is behind the kSystemExtensions > feature flag and will allow users to sideload a System Extensions. > > For now it just has a button that shows a dialog when pressed. > > Bug: 1192426 > Change-Id: Ib3717bc5fe390de1813612a5fdd75e70c8a65ed0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301576 > Reviewed-by: Christopher Lam <calamity@chromium.org> > Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Giovanni Ortuno Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#949849} Bug: 1192426 Change-Id: Icce18717e3899b6029726f0bf7b9a1afa486b765 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324507 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Owners-Override: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/main@{#949911}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )