[CodeHealth] Remove uses of ListValue::begin()/end() in /content/brow…

…ser/webrtc.

This CL removes calls to these deprecated member functions. It also
converts to the newer "for" loop syntax when possible, along with
other minor cleanup.

This CL was uploaded by git cl split.

R=emircan@chromium.org

Bug: 1187107
Change-Id: Ibfa5eae4f008bc6cfb4b9ca6234e360f300ac726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2876099
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#880441}

content/browser/webrtc/webrtc_getusermedia_browsertest.cc

@@ -143,11 +143,11 @@ class WebRtcGetUserMediaBrowserTest : public WebRtcContentBrowserTestBase {
     base::ListValue* values;
     ASSERT_TRUE(parsed_json.value->GetAsList(&values));
 
-    for (auto it = values->begin(); it != values->end(); ++it) {
+    for (const auto& entry : values->GetList()) {
       const base::DictionaryValue* dict;
       std::string kind;
       std::string device_id;
-      ASSERT_TRUE(it->GetAsDictionary(&dict));
+      ASSERT_TRUE(entry.GetAsDictionary(&dict));
       ASSERT_TRUE(dict->GetString("kind", &kind));
       ASSERT_TRUE(dict->GetString("id", &device_id));
       ASSERT_FALSE(device_id.empty());

content/browser/webrtc/webrtc_internals.cc

@@ -338,7 +338,7 @@ void WebRTCInternals::RemoveObserver(WebRTCInternalsUIObserver* observer) {
   DisableLocalEventLogRecordings();
 
   // TODO(tommi): Consider removing all the peer_connection_data_.
-  for (auto& dictionary : peer_connection_data_)
+  for (auto& dictionary : peer_connection_data_.GetList())
     FreeLogList(&dictionary);
 }
 
@@ -359,7 +359,7 @@ void WebRTCInternals::UpdateObserver(WebRTCInternalsUIObserver* observer) {
   if (peer_connection_data_.GetSize() > 0)
     observer->OnUpdate("update-all-peer-connections", &peer_connection_data_);
 
-  for (const auto& request : get_user_media_requests_) {
+  for (const auto& request : get_user_media_requests_.GetList()) {
     observer->OnUpdate("add-get-user-media", &request);
   }
 }

content/browser/webrtc/webrtc_internals_unittest.cc

@@ -210,7 +210,7 @@ TEST_F(WebRtcInternalsTest, EnsureNoLogWhenNoObserver) {
   ASSERT_TRUE(observer.event_data()->GetAsList(&list));
   EXPECT_EQ(1U, list->GetSize());
   base::DictionaryValue* dict = nullptr;
-  ASSERT_TRUE((*list->begin()).GetAsDictionary(&dict));
+  ASSERT_TRUE((*list->GetList().begin()).GetAsDictionary(&dict));
   base::ListValue* log = nullptr;
   ASSERT_FALSE(dict->GetList("log", &log));
 
@@ -239,7 +239,7 @@ TEST_F(WebRtcInternalsTest, EnsureLogIsRemovedWhenObserverIsRemoved) {
   ASSERT_TRUE(observer.event_data()->GetAsList(&list));
   EXPECT_EQ(1U, list->GetSize());
   base::DictionaryValue* dict = nullptr;
-  ASSERT_TRUE((*list->begin()).GetAsDictionary(&dict));
+  ASSERT_TRUE((*list->GetList().begin()).GetAsDictionary(&dict));
   base::ListValue* log = nullptr;
   ASSERT_TRUE(dict->GetList("log", &log));
 
@@ -250,7 +250,7 @@ TEST_F(WebRtcInternalsTest, EnsureLogIsRemovedWhenObserverIsRemoved) {
 
   ASSERT_TRUE(observer.event_data()->GetAsList(&list));
   EXPECT_EQ(1U, list->GetSize());
-  ASSERT_TRUE((*list->begin()).GetAsDictionary(&dict));
+  ASSERT_TRUE((*list->GetList().begin()).GetAsDictionary(&dict));
   ASSERT_FALSE(dict->GetList("log", &log));
 
   webrtc_internals.OnPeerConnectionRemoved(kFrameId, kLid);
@@ -410,7 +410,7 @@ TEST_F(WebRtcInternalsTest, SendAllUpdatesWithPeerConnectionUpdate) {
   EXPECT_EQ(1U, list->GetSize());
 
   base::DictionaryValue* dict = nullptr;
-  EXPECT_TRUE((*list->begin()).GetAsDictionary(&dict));
+  EXPECT_TRUE((*list->GetList().begin()).GetAsDictionary(&dict));
 
   VerifyInt(dict, "rid", kFrameId.child_id);
   VerifyInt(dict, "lid", kLid);
@@ -423,7 +423,7 @@ TEST_F(WebRtcInternalsTest, SendAllUpdatesWithPeerConnectionUpdate) {
   ASSERT_TRUE(dict->GetList("log", &log));
   EXPECT_EQ(1U, log->GetSize());
 
-  EXPECT_TRUE((*log->begin()).GetAsDictionary(&dict));
+  EXPECT_TRUE((*log->GetList().begin()).GetAsDictionary(&dict));
   VerifyString(dict, "type", update_type);
   VerifyString(dict, "value", update_value);
   std::string time;