Skip to content

Commit

Permalink
Moved rendering perf from //testing to //chrome/test
Browse files Browse the repository at this point in the history
Having rendering_representative_perf_tests on testing/BUILD.gn adds a
dependency into the //chrome tree for the //testing build process. This
CL merely moves the target to //chrome/test in order to remove this
dependency spread.

Change-Id: Iae6b25d5ddcf8d014f4ca9f8a47499244980b04d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635812
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666285}
  • Loading branch information
cdesouza-chromium authored and Commit Bot committed Jun 5, 2019
1 parent de7a87f commit fe94bf8
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 20 deletions.
19 changes: 19 additions & 0 deletions chrome/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -6265,6 +6265,25 @@ if (is_chromeos) {
}
}

if (is_mac || is_win) {
group("rendering_representative_perf_tests") {
testonly = true
deps = [
"//tools/perf/chrome_telemetry_build:telemetry_chrome_test",
]
data = [
"//build/android/pylib",
"//chrome/test/data/perf",
"//components/variations/service/generate_ui_string_overrider.py",
"//testing/scripts",
"//testing/test_env.py",
"//testing/xvfb.py",
"//third_party/catapult",
"//tools",
]
}
}

if (is_win) {
test("delayloads_unittests") {
output_name = "delayloads_unittests"
Expand Down
19 changes: 0 additions & 19 deletions testing/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -27,25 +27,6 @@ group("test_scripts_shared") {
]
}

if (is_mac || is_win) {
group("rendering_representative_perf_tests") {
testonly = true
deps = [
"//tools/perf/chrome_telemetry_build:telemetry_chrome_test",
]
data = [
"//build/android/pylib",
"//chrome/test/data/perf",
"//components/variations/service/generate_ui_string_overrider.py",
"//testing/scripts",
"//testing/test_env.py",
"//testing/xvfb.py",
"//third_party/catapult",
"//tools",
]
}
}

group("run_perf_test") {
data = [
"//testing/scripts/common.py",
Expand Down
2 changes: 1 addition & 1 deletion testing/buildbot/gn_isolate_map.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -2243,7 +2243,7 @@
"--output-format=csv",
"--browser=release",
],
"label": "//testing:rendering_representative_perf_tests",
"label": "//chrome/test:rendering_representative_perf_tests",
"script": "//testing/scripts/run_rendering_benchmark_with_gated_performance.py",
"type": "script",
},
Expand Down

0 comments on commit fe94bf8

Please sign in to comment.