Skip to content

Commit

Permalink
Fix histogram names.
Browse files Browse the repository at this point in the history
Mark three histograms obsolete and add new ones in histograms.xml to enable access to histograms renamed
in https://crrev.com/12710005.

BUG=425723

Review URL: https://codereview.chromium.org/637413007

Cr-Commit-Position: refs/heads/master@{#300674}
  • Loading branch information
bnc authored and Commit bot committed Oct 22, 2014
1 parent 2f4ca84 commit fd4440e
Showing 1 changed file with 30 additions and 0 deletions.
30 changes: 30 additions & 0 deletions tools/metrics/histograms/histograms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17944,6 +17944,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>

<histogram name="Net.SpdyConnectionLatency" units="milliseconds">
<obsolete>
Replaced by Net.SpdyConnectionLatency_2 on 2014-10-21.
</obsolete>
<owner>rch@chromium.org</owner>
<summary>Time from when the Connect() starts until it completes.</summary>
</histogram>

<histogram name="Net.SpdyConnectionLatency_2" units="milliseconds">
<owner>rch@chromium.org</owner>
<summary>Time from when the Connect() starts until it completes.</summary>
</histogram>
Expand Down Expand Up @@ -18255,6 +18263,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>

<histogram name="Net.SSL_Connection_Latency" units="milliseconds">
<obsolete>
Replaced by Net.SSL_Connection_Latency_2 on 2014-10-21.
</obsolete>
<owner>agl@chromium.org</owner>
<summary>Time from when the Connect() starts until it completes.</summary>
</histogram>

<histogram name="Net.SSL_Connection_Latency_2" units="milliseconds">
<owner>agl@chromium.org</owner>
<summary>Time from when the Connect() starts until it completes.</summary>
</histogram>
Expand All @@ -18273,6 +18289,17 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>

<histogram name="Net.SSL_Connection_Latency_Google" units="milliseconds">
<obsolete>
Replaced by Net.SSL_Connection_Latency_Google2 on 2014-10-21.
</obsolete>
<owner>agl@chromium.org</owner>
<summary>
Time from when the Connect() starts until it completes for google.com and
any subdomain of it.
</summary>
</histogram>

<histogram name="Net.SSL_Connection_Latency_Google2" units="milliseconds">
<owner>agl@chromium.org</owner>
<summary>
Time from when the Connect() starts until it completes for google.com and
Expand Down Expand Up @@ -57481,6 +57508,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<suffix name="FalseStart_enabled"/>
<suffix name="FalseStart_disabled"/>
<affected-histogram name="Net.SSL_Connection_Latency"/>
<affected-histogram name="Net.SSL_Connection_Latency_2"/>
<affected-histogram name="PLT.BeginToFinish_LinkLoadNormal"/>
<affected-histogram name="PLT.BeginToFinish_NormalLoad"/>
</histogram_suffixes>
Expand All @@ -57489,7 +57517,9 @@ To add a new entry, add it with any value and run test to compute valid value.
<suffix name="Resume_Handshake" label="Session Resumption"/>
<suffix name="Full_Handshake" label="Full"/>
<affected-histogram name="Net.SSL_Connection_Latency"/>
<affected-histogram name="Net.SSL_Connection_Latency_2"/>
<affected-histogram name="Net.SSL_Connection_Latency_Google"/>
<affected-histogram name="Net.SSL_Connection_Latency_Google2"/>
</histogram_suffixes>

<histogram_suffixes name="StartupTimeBombAlarm" separator=".">
Expand Down

0 comments on commit fd4440e

Please sign in to comment.