Skip to content

Commit

Permalink
android_dynamic_feature_modules.md: onDemand="false" splits are alway…
Browse files Browse the repository at this point in the history
…s installed

Bug: 1241142
Change-Id: Ifdc10fc26e05659012c5e292c4babf1589a5cb26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3104366
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#913133}
  • Loading branch information
agrieve authored and Chromium LUCI CQ committed Aug 18, 2021
1 parent 09d3d26 commit f0d9777
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions docs/android_dynamic_feature_modules.md
Original file line number Diff line number Diff line change
Expand Up @@ -213,12 +213,14 @@ To build and install the Monochrome bundle to your connected device, run:

```shell
$ autoninja -C $OUTDIR monochrome_public_bundle
$ $OUTDIR/bin/monochrome_public_bundle install -m base -m foo
$ $OUTDIR/bin/monochrome_public_bundle install -m foo
```

This will install Foo alongside the rest of Chrome. The rest of Chrome is called
_base_ module in the bundle world. The base module will always be put on the
device when initially installing Chrome.
This will install the `Foo` module, the `base` module, and all modules with an
`AndroidManifest.xml` that:
* Sets `<module dist:onDemand="false">`, or
* Has `<dist:delivery>` conditions that are satisfied by the device being
installed to.

*** note
**Note:** The install script may install more modules than you specify, e.g.
Expand All @@ -237,7 +239,7 @@ Then try installing the Monochrome bundle without your module and print the
installed modules:

```shell
$ $OUTDIR/bin/monochrome_public_bundle install -m base
$ $OUTDIR/bin/monochrome_public_bundle install
$ adb shell dumpsys package org.chromium.chrome | grep splits
> splits=[base, config.en]
```
Expand Down Expand Up @@ -871,7 +873,7 @@ core's `--local-testing` [mode][play-core-local-testing].
Fake-install and launch Chrome with the following command:

```shell
$ $OUTDIR/bin/monochrome_public_bundle install -m base -f foo
$ $OUTDIR/bin/monochrome_public_bundle install -f foo
$ $OUTDIR/bin/monochrome_public_bundle launch
```

Expand Down

0 comments on commit f0d9777

Please sign in to comment.