Skip to content

Commit

Permalink
Delete PasswordStoreMac and SimplePasswordStoreMac.
Browse files Browse the repository at this point in the history
Keychain usage for passwords is finally deprecated. The only functional change for the users is that we stop cleaning up the passwords in Keychain. PasswordStoreMac wasn't instantiated before this CL.

BUG=466638

Review-Url: https://codereview.chromium.org/2909283002
Cr-Commit-Position: refs/heads/master@{#475547}
  • Loading branch information
vasilii authored and Commit Bot committed May 30, 2017
1 parent 6a65f61 commit efe5bab
Show file tree
Hide file tree
Showing 17 changed files with 56 additions and 4,622 deletions.
5 changes: 0 additions & 5 deletions chrome/browser/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -888,15 +888,10 @@ split_static_library("browser") {
"password_manager/password_manager_util_win.h",
"password_manager/password_store_factory.cc",
"password_manager/password_store_factory.h",
"password_manager/password_store_mac.cc",
"password_manager/password_store_mac.h",
"password_manager/password_store_mac_internal.h",
"password_manager/password_store_proxy_mac.cc",
"password_manager/password_store_proxy_mac.h",
"password_manager/password_store_win.cc",
"password_manager/password_store_win.h",
"password_manager/simple_password_store_mac.cc",
"password_manager/simple_password_store_mac.h",
"payments/ssl_validity_checker.cc",
"payments/ssl_validity_checker.h",
"performance_monitor/performance_monitor.cc",
Expand Down
4 changes: 2 additions & 2 deletions chrome/browser/password_manager/password_store_factory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@ PasswordStoreFactory::BuildServiceInstanceFor(
os_crypt::switches::kUseMockKeychain)
? new crypto::MockAppleKeychain()
: new crypto::AppleKeychain());
ps = new PasswordStoreProxyMac(main_thread_runner, std::move(keychain),
std::move(login_db), profile->GetPrefs());
ps = new PasswordStoreProxyMac(main_thread_runner, std::move(login_db),
profile->GetPrefs());
#elif defined(OS_CHROMEOS) || defined(OS_ANDROID)
// For now, we use PasswordStoreDefault. We might want to make a native
// backend for PasswordStoreX (see below) in the future though.
Expand Down
Loading

0 comments on commit efe5bab

Please sign in to comment.