Run clang-tidy modernize-use-equals-{delete,default} on //apps

See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 Change-Id: I0085476ed1fd901c9de97c91d2e12cc1d3faa1af Reviewed-on: https://chromium-review.googlesource.com/789738 Commit-Queue: Chris Watkins <watk@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#519211}
FairyWorld · Nov 27, 2017 · ee8488b · ee8488b
1 parent c554433
commit ee8488b
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 9 deletions.
diff --git a/apps/app_lifetime_monitor.cc b/apps/app_lifetime_monitor.cc
@@ -35,7 +35,7 @@ AppLifetimeMonitor::AppLifetimeMonitor(content::BrowserContext* context)
   app_window_registry->AddObserver(this);
 }
 
-AppLifetimeMonitor::~AppLifetimeMonitor() {}
+AppLifetimeMonitor::~AppLifetimeMonitor() = default;
 
 void AppLifetimeMonitor::AddObserver(Observer* observer) {
   observers_.AddObserver(observer);

diff --git a/apps/app_lifetime_monitor_factory.cc b/apps/app_lifetime_monitor_factory.cc
@@ -30,7 +30,7 @@ AppLifetimeMonitorFactory::AppLifetimeMonitorFactory()
   DependsOn(extensions::AppWindowRegistry::Factory::GetInstance());
 }
 
-AppLifetimeMonitorFactory::~AppLifetimeMonitorFactory() {}
+AppLifetimeMonitorFactory::~AppLifetimeMonitorFactory() = default;
 
 KeyedService* AppLifetimeMonitorFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {

diff --git a/apps/app_restore_service_factory.cc b/apps/app_restore_service_factory.cc
@@ -29,8 +29,7 @@ AppRestoreServiceFactory::AppRestoreServiceFactory()
   DependsOn(AppLifetimeMonitorFactory::GetInstance());
 }
 
-AppRestoreServiceFactory::~AppRestoreServiceFactory() {
-}
+AppRestoreServiceFactory::~AppRestoreServiceFactory() = default;
 
 KeyedService* AppRestoreServiceFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {

diff --git a/apps/launcher.cc b/apps/launcher.cc
@@ -165,7 +165,7 @@ class PlatformAppPathLauncher
  private:
   friend class base::RefCountedThreadSafe<PlatformAppPathLauncher>;
 
-  virtual ~PlatformAppPathLauncher() {}
+  virtual ~PlatformAppPathLauncher() = default;
 
   void MakePathAbsolute(const base::FilePath& current_directory) {
     for (std::vector<base::FilePath>::iterator it = entry_paths_.begin();

diff --git a/apps/saved_files_service.cc b/apps/saved_files_service.cc
@@ -190,7 +190,7 @@ SavedFilesService::SavedFilesService(content::BrowserContext* context)
                  content::NotificationService::AllSources());
 }
 
-SavedFilesService::~SavedFilesService() {}
+SavedFilesService::~SavedFilesService() = default;
 
 void SavedFilesService::Observe(int type,
                                 const content::NotificationSource& source,
@@ -287,7 +287,7 @@ SavedFilesService::SavedFiles::SavedFiles(content::BrowserContext* context,
   LoadSavedFileEntriesFromPreferences();
 }
 
-SavedFilesService::SavedFiles::~SavedFiles() {}
+SavedFilesService::SavedFiles::~SavedFiles() = default;
 
 void SavedFilesService::SavedFiles::RegisterFileEntry(
     const std::string& id,

diff --git a/apps/saved_files_service_factory.cc b/apps/saved_files_service_factory.cc
@@ -34,7 +34,7 @@ SavedFilesServiceFactory::SavedFilesServiceFactory()
           "SavedFilesService",
           BrowserContextDependencyManager::GetInstance()) {}
 
-SavedFilesServiceFactory::~SavedFilesServiceFactory() {}
+SavedFilesServiceFactory::~SavedFilesServiceFactory() = default;
 
 KeyedService* SavedFilesServiceFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {

diff --git a/apps/ui/views/app_window_frame_view.cc b/apps/ui/views/app_window_frame_view.cc
@@ -55,7 +55,7 @@ AppWindowFrameView::AppWindowFrameView(views::Widget* widget,
       resize_area_corner_size_(kDefaultResizeAreaCornerSize) {
 }
 
-AppWindowFrameView::~AppWindowFrameView() {}
+AppWindowFrameView::~AppWindowFrameView() = default;
 
 void AppWindowFrameView::Init() {
   if (draw_frame_) {