Print Preview: Change page title to be more descriptive for screen re…

…aders Bug: 987318 Change-Id: I7c8943f15724e6387c5a1a9fc1666c1940422020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486459 Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#819404}
FairyWorld · Oct 21, 2020 · ed6b0c6 · ed6b0c6
1 parent 3c80ef1
commit ed6b0c6
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 1 deletion.
diff --git a/chrome/app/printing_strings.grdp b/chrome/app/printing_strings.grdp
@@ -16,6 +16,9 @@
     <message name="IDS_PRINT_PREVIEW_TITLE" desc="Fallback title for print preview page.">
       Print
     </message>
+    <message name="IDS_PRINT_PREVIEW_DESCRIPTION" desc="Accessibility text: title/description of the Print Preview dialog Web Contents, read by screenreaders.">
+      Print preview dialog
+    </message>
     <message name="IDS_PRINT_PREVIEW_LOADING" desc="Message to display while the print preview is still loading.">
       Loading preview
     </message>

diff --git a/chrome/app/printing_strings_grdp/IDS_PRINT_PREVIEW_DESCRIPTION.png.sha1 b/chrome/app/printing_strings_grdp/IDS_PRINT_PREVIEW_DESCRIPTION.png.sha1
@@ -0,0 +1 @@
+4cebd4f475de4a4c1bbcd7c815aebe5efd2a204e
diff --git a/chrome/browser/resources/print_preview/print_preview.html b/chrome/browser/resources/print_preview/print_preview.html
@@ -1,7 +1,7 @@
 <!doctype html>
 <html dir="$i18n{textdirection}" lang="$i18n{language}" class="loading">
 <head>
-  <title>$i18n{title}</title>
+  <title>$i18n{pageDescription}</title>
   <meta charset="utf-8">
   <base href="chrome://print">
   <style>

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
@@ -271,6 +271,7 @@ void AddPrintPreviewStrings(content::WebUIDataSource* source) {
     {"optionShortEdge", IDS_PRINT_PREVIEW_OPTION_SHORT_EDGE},
     {"optionTwoSided", IDS_PRINT_PREVIEW_OPTION_TWO_SIDED},
     {"optionsLabel", IDS_PRINT_PREVIEW_OPTIONS_LABEL},
+    {"pageDescription", IDS_PRINT_PREVIEW_DESCRIPTION},
     {"pageRangeLimitInstructionWithValue",
      IDS_PRINT_PREVIEW_PAGE_RANGE_LIMIT_INSTRUCTION_WITH_VALUE},
     {"pageRangeSyntaxInstruction",