Skip to content

Commit

Permalink
Add Recommended / Deprecated comments on HeapMojoWrapperMode
Browse files Browse the repository at this point in the history
HeapMojoWrapperMode provides tentative modes so that we can keep the original behaviour. But we need to enphasize to use kWithContextObserver.

Bug: 1049056
Change-Id: I4ab677a60f1c91824f83f3c29c6c0c2a3cc9e3ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345935
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796757}
  • Loading branch information
chikamune-cr authored and Commit Bot committed Aug 11, 2020
1 parent 92ec733 commit ec791fb
Showing 1 changed file with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,17 @@ namespace blink {
// TODO(crbug.com/1058076) This is just a temporary thing to keep the existing
// behavior during the release freeze.
enum class HeapMojoWrapperMode {
// Resets the mojo connection when 1) the owner object is garbage-collected
// [Recommended] Resets the mojo connection when 1) the owner object is
// garbage-collected
// and 2) the associated ExecutionContext is detached.
kWithContextObserver,
// Resets the mojo connection when the owner object is garbage-collected.
// [Deprecated] Resets the mojo connection when the owner object is
// garbage-collected.
// But, it will not reset the mojo connection when the associated
// ExecutionContext is detached.
kWithoutContextObserver,
// We are now experimenting with deprecating kWithoutContextObserver.
// [Deprecated] We are now experimenting with deprecating
// kWithoutContextObserver.
// kWithoutContextObserver is ignored in the Finch experiment. To enforce
// kWithoutContextObserver, use kForceWithoutContextObserver.
kForceWithoutContextObserver,
Expand Down

0 comments on commit ec791fb

Please sign in to comment.