Skip to content

Commit

Permalink
fix: compilation error on Windows on Arm
Browse files Browse the repository at this point in the history
Enums can be unsigned or signed. This change corrects an unsigned/signed
comparison error by making sure this enum is always unsigned.

Bug: 1141421
Change-Id: Ic3576497c77fd6e3391e6d42a4653c699f337a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493201
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Cr-Commit-Position: refs/heads/master@{#820057}
  • Loading branch information
richard-townsend-arm authored and Commit Bot committed Oct 22, 2020
1 parent e23c00e commit e94604a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion base/immediate_crash_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ using Instruction = uint32_t;
// Use an enum here rather than separate constexpr vars because otherwise some
// of the vars will end up unused on each platform, upsetting
// -Wunused-const-variable.
enum {
enum : Instruction {
// There are multiple valid encodings of return (which is really a special
// form of branch). This is the one clang seems to use:
kRet = 0xd65f03c0,
Expand Down

0 comments on commit e94604a

Please sign in to comment.